candidate app builds require fixed daemon candidate #670

Closed
opened 2017-10-11 21:39:24 +02:00 by jackrobison · 4 comments
jackrobison commented 2017-10-11 21:39:24 +02:00 (Migrated from github.com)

The Issue

For example, app 0.17.0rc1 requires daemon 0.17.0rc13 exactly.

Expected behaviour

Any daemon RC of the same version should work, or at very least every RC >= the bundled daemon (rc14, 15, etc should work).

Actual behaviour

The app shuts down after saying the daemon is incompatible.

## The Issue For example, app 0.17.0rc1 requires daemon 0.17.0rc13 exactly. ### Expected behaviour Any daemon RC of the same version should work, or at very least every RC >= the bundled daemon (rc14, 15, etc should work). ### Actual behaviour The app shuts down after saying the daemon is incompatible.
liamcardenas commented 2017-11-20 21:55:28 +01:00 (Migrated from github.com)

@kauffj should we prioritize this issue highly? It would help with future daemon testing

@kauffj should we prioritize this issue highly? It would help with future daemon testing
kauffj commented 2017-11-20 22:27:49 +01:00 (Migrated from github.com)

@liamcardenas sure, it's an easy one. Just fix this line:

https://github.com/lbryio/lbry-app/blob/master/ui/js/redux/actions/app.js#L156

However, you need to use a comparison check that can properly handle version numbers, including RCs.

@liamcardenas sure, it's an easy one. Just fix this line: https://github.com/lbryio/lbry-app/blob/master/ui/js/redux/actions/app.js#L156 However, you need to use a comparison check that can properly handle version numbers, including RCs.
alyssaoc commented 2018-08-28 19:42:05 +02:00 (Migrated from github.com)

closed, this has been fixed

closed, this has been fixed
tzarebczan commented 2018-08-28 19:44:15 +02:00 (Migrated from github.com)

Fixed in dev mode, will open a ticket for prod mode.

Fixed in dev mode, will open a ticket for prod mode.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#670
No description provided.