Anthony watchman integration #6799
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#6799
Loading…
Reference in a new issue
No description provided.
Delete branch "anthony-watchman-integration"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Addresses: https://github.com/lbryio/lbry-desktop/issues/6437
just small stuff.
I think it's fine in this file for now.
an analytics folder with a file per system might be nice, but there are bigger fish.
this doesn't seem to change - is it const? duration of what could be in the name?
var -> let
console.log
I think we can put this URL somewhere - maybe config, maybe a constant. Preferably a config.
console log
consolelog
console.log
@ -79,0 +124,4 @@
}
// current position in video in MS
const positionInVideo = Math.round(videoPlayer.currentTime()) * 1000;
This sort of thing, if tested elsewhere should use a constant, make a new file in constants if necessary.
this still current? "...display and" ?
consolelogs
let