Anthony watchman integration #6799

Merged
mayeaux merged 20 commits from anthony-watchman-integration into master 2021-08-10 22:42:50 +02:00
mayeaux commented 2021-08-06 17:49:08 +02:00 (Migrated from github.com)
Addresses: https://github.com/lbryio/lbry-desktop/issues/6437
jessopb (Migrated from github.com) reviewed 2021-08-09 23:36:59 +02:00
jessopb (Migrated from github.com) left a comment

just small stuff.
I think it's fine in this file for now.
an analytics folder with a file per system might be nice, but there are bigger fish.

just small stuff. I think it's fine in this file for now. an analytics folder with a file per system might be nice, but there are bigger fish.
jessopb (Migrated from github.com) commented 2021-08-09 23:10:45 +02:00

this doesn't seem to change - is it const? duration of what could be in the name?

this doesn't seem to change - is it const? duration of what could be in the name?
jessopb (Migrated from github.com) commented 2021-08-09 23:10:57 +02:00

var -> let

var -> let
jessopb (Migrated from github.com) commented 2021-08-09 23:12:03 +02:00

console.log

console.log
jessopb (Migrated from github.com) commented 2021-08-09 23:14:35 +02:00

I think we can put this URL somewhere - maybe config, maybe a constant. Preferably a config.

I think we can put this URL somewhere - maybe config, maybe a constant. Preferably a config.
jessopb (Migrated from github.com) commented 2021-08-09 23:15:47 +02:00

console log

console log
jessopb (Migrated from github.com) commented 2021-08-09 23:19:01 +02:00

consolelog

consolelog
jessopb (Migrated from github.com) commented 2021-08-09 23:20:53 +02:00

console.log

console.log
@ -79,0 +124,4 @@
}
// current position in video in MS
const positionInVideo = Math.round(videoPlayer.currentTime()) * 1000;
jessopb (Migrated from github.com) commented 2021-08-09 23:09:01 +02:00

This sort of thing, if tested elsewhere should use a constant, make a new file in constants if necessary.

This sort of thing, if tested elsewhere should use a constant, make a new file in constants if necessary.
jessopb (Migrated from github.com) commented 2021-08-09 23:16:38 +02:00

this still current? "...display and" ?

this still current? "...display and" ?
jessopb (Migrated from github.com) commented 2021-08-09 23:17:40 +02:00

consolelogs

consolelogs
jessopb (Migrated from github.com) commented 2021-08-09 23:17:57 +02:00

let

let
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#6799
No description provided.