LBRYCommunity/lbry-desktop

Fork 0

Creator: Enable "min tips" and "min hyperchat" #6824

Merged

infinite-persistence merged 6 commits from ip/min.tips into master

2021-08-13 04:41:02 +02:00

infinite-persistence commented

2021-08-09 16:36:56 +02:00

(Migrated from github.com)

Issue

Closes #6119 (min tips)

Test

jimbo.lbry.tv (⚠️ different test instance from usual -- troublesome to merge with existing PRs multiple times).

General description of changes

"Creator Settings" page now include a "Min Tip" and "Min Hyper Chat" amount setting.
An advisory text will be displayed beside the comment-create submission button to indicate the minimum amount. For livestreams, and additional bubble will appear to describe the min hyper chat amount.

Concerns

How does fiat-comments come into play?
There is no mechanism to avoid mismatched payment. I tried to handle it as much as possible, as describe in the Notion post.

## Issue Closes #6119 (min tips) ## Test jimbo.lbry.tv (⚠️ different test instance from usual -- troublesome to merge with existing PRs multiple times). ## General description of changes - "Creator Settings" page now include a "Min Tip" and "Min Hyper Chat" amount setting. - An advisory text will be displayed beside the comment-create submission button to indicate the minimum amount. For livestreams, and additional bubble will appear to describe the min hyper chat amount. ## Concerns - How does fiat-comments come into play? - There is no mechanism to avoid mismatched payment. I tried to handle it as much as possible, as describe in the Notion post.

tzarebczan (Migrated from github.com) reviewed 2021-08-09 16:36:56 +02:00

infinite-persistence commented

2021-08-11 03:42:56 +02:00

(Migrated from github.com)

Found few items to improve while testing. Setting back to DRAFT.

Found few items to improve while testing. Setting back to `DRAFT`.

infinite-persistence commented

2021-08-11 04:51:16 +02:00

(Migrated from github.com)

4a4f6d9 to 6dbd24b (ready for review at Jimbo)

Use a less-verbose notice message on amount. Push the verbose version as a tooltip instead.
- Before-and-after
  - -->
Fetch setting.Get when clicking the LBC icon as well (try to get the latest value as frequent as possible, but not too frequent).

### 4a4f6d9 to 6dbd24b (ready for review at Jimbo) - Use a less-verbose notice message on amount. Push the verbose version as a tooltip instead. - Before-and-after - <img src="https://user-images.githubusercontent.com/64950861/128961924-321949a6-e6e5-47fa-8174-1c969993bd0b.png" width="300"> --> <img src="https://user-images.githubusercontent.com/64950861/128962012-5e19e4e0-92a3-4d1a-a45a-ea370c84a479.png" width="300"> - Fetch `setting.Get` when clicking the LBC icon as well (try to get the latest value as frequent as possible, but not too frequent).

infinite-persistence (Migrated from github.com) reviewed 2021-08-11 04:59:47 +02:00

flow-typed/Comment.js

infinite-persistence (Migrated from github.com) commented

2021-08-11 04:59:37 +02:00

Note that Commentron seem to enforce a minimum amount of 0.01. Not sure if this is good or bad.
Setting to anything smaller like 0.001 will automatically reset to 0. It would be nicer if it clamped to 0.01 instead.

Note that Commentron seem to enforce a minimum amount of `0.01`. Not sure if this is good or bad. Setting to anything smaller like `0.001` will automatically reset to `0`. It would be nicer if it clamped to `0.01` instead.

tzarebczan (Migrated from github.com) reviewed 2021-08-11 05:55:01 +02:00

flow-typed/Comment.js

tzarebczan (Migrated from github.com) commented

2021-08-11 05:55:01 +02:00

I think a min of 0.01 is fine.

tzarebczan commented

2021-08-11 05:59:34 +02:00

(Migrated from github.com)

Looking great, I know some creators that are waiting to get their hands on this.

Reiterating feedback from Slack:

grey out min hyperchat if min comment is used. If hyperchat is filled, and then comment amount is added, reset hyperchat amount. Or maybe grey out in both cases (i.e. if hyperchat min is used, grey out comments)? Add note: "This setting not available if all comments require a tip" (and vice versa for other if we go that route).
fix regular comments when min hyperchat is used (missing the notification)
improve error message if comment is less than min comment/hyperchat amount
I adjusted commentron to not apply these settings for creators. The UI can still show the message, but should allow creator to send messages regarldess. I.e. I may want to pin something.

Looking great, I know some creators that are waiting to get their hands on this. Reiterating feedback from Slack: - [x] grey out min hyperchat if min comment is used. If hyperchat is filled, and then comment amount is added, reset hyperchat amount. Or maybe grey out in both cases (i.e. if hyperchat min is used, grey out comments)? Add note: "This setting not available if all comments require a tip" (and vice versa for other if we go that route). - [x] fix regular comments when min hyperchat is used (missing the notification) - [x] improve error message if comment is less than min comment/hyperchat amount - [x] I adjusted commentron to not apply these settings for creators. The UI can still show the message, but should allow creator to send messages regarldess. I.e. I may want to pin something.

infinite-persistence commented

2021-08-11 18:18:32 +02:00

(Migrated from github.com)

6dbd24b to c8f41a8

Ready for re-review, and I'll test more tomorrow.

Covered all 4 items mentioned above.
Improved the amount checking. As long as the setting changed after user entered the "Review" stage, we prompt a toast asking the user to double-confirm. This also covers the case of creator lowering the setting (prevent overpay).

Commentron Issues:

Commentron should provide better error when out of range:
The scenario is prevented in the GUI now, but Commentron produces error in satoshis

### 6dbd24b to c8f41a8 Ready for re-review, and I'll test more tomorrow. - Covered all 4 items mentioned above. - Improved the amount checking. As long as the setting changed after user entered the "Review" stage, we prompt a toast asking the user to double-confirm. This also covers the case of creator lowering the setting (prevent overpay). Commentron Issues: - [ ] Commentron should provide better error when out of range: - <img src="https://user-images.githubusercontent.com/64950861/129064504-756ddc96-5b9d-4edd-a9ee-17c92ea09264.png" width="300"> - [ ] The scenario is prevented in the GUI now, but Commentron produces error in satoshis - <img src="https://user-images.githubusercontent.com/64950861/129065648-ddb3bf4e-3102-4e47-9dd3-bf0c8d72bf59.png" >

tzarebczan commented

2021-08-11 22:24:08 +02:00

(Migrated from github.com)

This is working great! @jessopb please merge after your review.

infinite-persistence commented

2021-08-12 03:46:33 +02:00

(Migrated from github.com)

c8f41a8 to 799a194