Stripe integration fix #6850

Merged
jessopb merged 25 commits from stripe-integration-fix into master 2021-08-11 22:58:56 +02:00
jessopb commented 2021-08-10 19:23:57 +02:00 (Migrated from github.com)
No description provided.
jessopb (Migrated from github.com) reviewed 2021-08-10 21:46:53 +02:00
@ -38,38 +37,27 @@ export default function LivestreamComments(props: Props) {
embed,
doCommentSocketConnect,
jessopb (Migrated from github.com) commented 2021-08-10 21:12:41 +02:00

Can we use better variable names rather than comments in cases like these?

Can we use better variable names rather than comments in cases like these?
jessopb (Migrated from github.com) commented 2021-08-10 21:13:51 +02:00

destructure props with const. we usually don't mutate passed props.

destructure props with const. we usually don't mutate passed props.
jessopb (Migrated from github.com) commented 2021-08-10 21:15:10 +02:00

is it even in props?

is it even in props?
jessopb (Migrated from github.com) commented 2021-08-10 21:18:36 +02:00

I wonder if flow will complain that livestreamCommentsDiv could be undefined, so next line could break.

I wonder if flow will complain that livestreamCommentsDiv could be undefined, so next line could break.
jessopb (Migrated from github.com) commented 2021-08-10 21:26:01 +02:00

I think a single component doesn't need a fragment <> wrapper.

I think a single <card> component doesn't need a fragment <> wrapper.
jessopb (Migrated from github.com) commented 2021-08-10 21:23:27 +02:00

reselect boilerplate. let's get rid of this comment

reselect boilerplate. let's get rid of this comment
@ -186,4 +177,4 @@
clientSecret = customerSetupResponse.client_secret;
// instantiate stripe elements
setupStripe();
jessopb (Migrated from github.com) commented 2021-08-10 21:25:24 +02:00

Just put these like
CARD_SETUP_ERROR = __('blah');
API_SERVER_ERROR = __('bleg'); at the top.

Just put these like CARD_SETUP_ERROR = __('blah'); API_SERVER_ERROR = __('bleg'); at the top.
mayeaux (Migrated from github.com) reviewed 2021-08-10 22:22:00 +02:00
mayeaux (Migrated from github.com) commented 2021-08-10 22:22:00 +02:00

It doesn't, just the two things I mentioned before

It doesn't, just the two things I mentioned before
mayeaux (Migrated from github.com) reviewed 2021-08-10 22:29:46 +02:00
mayeaux (Migrated from github.com) commented 2021-08-10 22:29:46 +02:00

nope you're right actually lol

nope you're right actually lol
jessopb (Migrated from github.com) reviewed 2021-08-11 20:44:16 +02:00
jessopb (Migrated from github.com) commented 2021-08-11 20:42:39 +02:00

'Please try again later.'
i18n __()

'Please try again later.' i18n __()
jessopb (Migrated from github.com) commented 2021-08-11 20:20:56 +02:00

i18n __() Also we'll want to change this copy.

i18n __() Also we'll want to change this copy.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#6850
No description provided.