Stripe integration fix #6850
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#6850
Loading…
Reference in a new issue
No description provided.
Delete branch "stripe-integration-fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -38,38 +37,27 @@ export default function LivestreamComments(props: Props) {
embed,
doCommentSocketConnect,
Can we use better variable names rather than comments in cases like these?
destructure props with const. we usually don't mutate passed props.
is it even in props?
I wonder if flow will complain that livestreamCommentsDiv could be undefined, so next line could break.
I think a single component doesn't need a fragment <> wrapper.
reselect boilerplate. let's get rid of this comment
@ -186,4 +177,4 @@
clientSecret = customerSetupResponse.client_secret;
// instantiate stripe elements
setupStripe();
Just put these like
CARD_SETUP_ERROR = __('blah');
API_SERVER_ERROR = __('bleg'); at the top.
It doesn't, just the two things I mentioned before
nope you're right actually lol
'Please try again later.'
i18n __()
i18n __() Also we'll want to change this copy.