send recsys powered-by #6875

2021-08-13T00:12:03+02:00

jessopb commented

2021-08-13 00:12:03 +02:00

(Migrated from github.com)

No description provided.

jessopb commented

2021-08-13 02:59:25 +02:00

(Migrated from github.com)

Had to change urisByQuery to resultsByQuery so that I could store the recsys id with the query since it changes by load balancer.

infinite-persistence (Migrated from github.com) reviewed 2021-08-13 04:35:54 +02:00

infinite-persistence (Migrated from github.com) left a comment

👍 Good to go with the following issues left:

:+1: Good to go with the following issues left:

ui/redux/selectors/search.js

					
				@ -26,9 +27,9 @@ export const selectSearchOptions: (state: State) => SearchOptions = createSelect

				export const selectIsSearching: (state: State) => boolean = createSelector(selectState, (state) => state.searching);

infinite-persistence (Migrated from github.com) commented

2021-08-13 04:33:45 +02:00

Maybe a rename would be good to reflect the actual returned object.

ui/redux/selectors/search.js

infinite-persistence (Migrated from github.com) commented

2021-08-13 04:12:38 +02:00

Wunderbar broke a bit (not sure if it's specifically due to this line or not)

Steps to reproduce:

Homepage
Search something in Wunderbar and press enter (I used "manchester"). We'll end up in the Search Page.
Clear Wunderbar and type "manchester" again but don't press enter.
- In the drop down, Most Supported appears, but Search results is blank. Reverted the change and Search results will appear.

Wunderbar broke a bit (not sure if it's specifically due to this line or not) Steps to reproduce: 1. Homepage 2. Search something in Wunderbar and press enter (I used "manchester"). We'll end up in the Search Page. 3. Clear Wunderbar and type "manchester" again but don't press enter. - In the drop down, `Most Supported` appears, but `Search results` is blank. Reverted the change and `Search results` will appear.

infinite-persistence (Migrated from github.com) approved these changes 2021-08-17 04:10:14 +02:00

Sign in to join this conversation.

No reviewers

infinite-persistence

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#6875

				`@ -26,9 +27,9 @@ export const selectSearchOptions: (state: State) => SearchOptions = createSelect`

				`export const selectIsSearching: (state: State) => boolean = createSelector(selectState, (state) => state.searching);`