Clear player position if on playlist. #6943

Merged
Ruk33 merged 1 commit from 6940-playlist-stop-fix into master 2021-08-25 21:35:00 +02:00
Ruk33 commented 2021-08-24 00:50:43 +02:00 (Migrated from github.com)

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/6940

What is the current behavior?

The autoplay doesn't behave properly when videos are already watched.

What is the new behavior?

The video's position will be clear if playing a playlist.

Other information

PR Type & Checklist

PR Type...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:
PR Checklist...

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below
## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/6940 <!-- Tip: - Add keywords to directly close the Issue when the PR is merged. - Skip the keyword if the Issue contains multiple items. - https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## What is the current behavior? The autoplay doesn't behave properly when videos are already watched. ## What is the new behavior? The video's position will be clear if playing a playlist. ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. --> ## PR Type & Checklist <details><summary>PR Type...</summary> What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: </details> <!----------------------------------------------------------------------------> <details><summary>PR Checklist...</summary> <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I added a line describing my change to CHANGELOG.md - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below </details>
tzarebczan commented 2021-08-24 16:59:02 +02:00 (Migrated from github.com)

Thanks @Ruk33 , we'll get a review on this soon!

Thanks @Ruk33 , we'll get a review on this soon!
jessopb (Migrated from github.com) approved these changes 2021-08-25 16:32:29 +02:00
jessopb (Migrated from github.com) left a comment

Looks good

Looks good
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#6943
No description provided.