LBRYCommunity/lbry-desktop

Fork 0

In-App notifications. #695

New issue

Closed

opened 2017-10-23 19:45:11 +02:00 by hackrush01 · 15 comments

hackrush01 commented

2017-10-23 19:45:11 +02:00

(Migrated from github.com)

Inclusion of an in-app notification system would be helpful in many cases such as if we want the people to move from slack to discord, we could just send an in-app notification for the same. It could be extended to other functionalities such as informing about incoming tips, new content, new upload from subscriptions etc.

Inclusion of an in-app notification system would be helpful in many cases such as if we want the people to move from slack to [discord](https://discord.gg/VuDpEyg), we could just send an in-app notification for the same. It could be extended to other functionalities such as informing about incoming tips, new content, new upload from subscriptions etc.

👍 2

tzarebczan commented

2018-06-29 21:55:21 +02:00

(Migrated from github.com)

Notification scenarios, including the ones mentioned above:

Publish completed
Download completed
Incoming tip
Incoming content payment
Received LBC
New content in subbed channels
Trending content
Pushed notifications from LBRY about app features / news / content / creators
LBRY app updates
System outages
Vanity URL outbid

Notification scenarios, including the ones mentioned above: - Publish completed - Download completed - Incoming tip - Incoming content payment - Received LBC - New content in subbed channels - Trending content - Pushed notifications from LBRY about app features / news / content / creators - LBRY app updates - System outages - Vanity URL outbid

👍 2

alyssaoc commented

2018-08-28 19:49:00 +02:00

(Migrated from github.com)

@seanyesmunt This should be considered for an epic

btzr-io commented

2018-09-09 04:50:07 +02:00

(Migrated from github.com)

WIP (Just the ui, no redux logic yet)

@seanyesmunt any ideas or feedback on this?

#### WIP (Just the ui, no redux logic yet) @seanyesmunt any ideas or feedback on this? ![notify](https://user-images.githubusercontent.com/14793624/45260555-e6546100-b3a7-11e8-913c-8cab0d17d156.png)

kauffj commented

2018-09-09 21:21:49 +02:00

(Migrated from github.com)

Ooooooh I love this. Not Sean but some quick comments from me:

It'd be cool if it showed the number of notifications
I'd keep the design consistent. Keep the spacing allocated for the image/icon the same, as well as the header formatting (unless you just couldn't get this to work...)
Consider adding elements that allow marking notifications as read or to hide them (see how FB manages theirs)
Less stylistic weight could be given to the header

Ooooooh I love this. Not Sean but some quick comments from me: 1) It'd be cool if it showed the number of notifications 2) I'd keep the design consistent. Keep the spacing allocated for the image/icon the same, as well as the header formatting (unless you just couldn't get this to work...) 3) Consider adding elements that allow marking notifications as read or to hide them (see how FB manages theirs) 4) Less stylistic weight could be given to the header

👍 1

btzr-io commented

2018-09-10 04:29:15 +02:00

(Migrated from github.com)

Some minor updates, still working on 3

![notify](https://user-images.githubusercontent.com/14793624/45273211-c20f8780-b46e-11e8-94c3-b9a838536842.gif) Some minor updates, still working on `3`

btzr-io commented

2018-09-10 04:40:58 +02:00

(Migrated from github.com)

![colors](https://user-images.githubusercontent.com/14793624/45273584-9d1c1400-b470-11e8-94c1-44db13003a29.png)

neb-b commented

2018-09-10 17:09:12 +02:00

(Migrated from github.com)

This is awesome @btzr-io.

I agree with @kauffj's comments. Maybe add an x in the corner when you hover over one notification to remove it from the stack. For the redux side this should live inlbry-redux. Probably in the notifications reducer.

I think to keep it simple we can just start with adding newly subscribed content and your publish confirmations: "Your file at lbry://something is published" or something similar.

This is awesome @btzr-io. I agree with @kauffj's comments. Maybe add an `x` in the corner when you hover over one notification to remove it from the stack. For the redux side this should live in`lbry-redux`. Probably in the `notifications` reducer. I think to keep it simple we can just start with adding newly subscribed content and your publish confirmations: `"Your file at lbry://something is published"` or something similar.

👍 1

neb-b commented

2018-09-10 17:10:21 +02:00

(Migrated from github.com)

Also this should use theFileTile component to keep it consistent with search/related content.

Also this should use the`FileTile` component to keep it consistent with search/related content.

👍 1

btzr-io commented

2018-09-13 02:01:41 +02:00

(Migrated from github.com)

publish confirmations: "Your file at lbry://something is published"

@seanyesmunt There is a modal for that, should I remove it?

> publish confirmations: "Your file at lbry://something is published" @seanyesmunt There is a modal for that, should I remove it?

btzr-io commented

2018-09-13 04:26:27 +02:00

(Migrated from github.com)

![remove-notify](https://user-images.githubusercontent.com/14793624/45463525-c08dcb80-b6c9-11e8-9754-3ae027421da2.gif)

neb-b commented

2018-09-17 01:15:34 +02:00

(Migrated from github.com)

@btzr-io Sorry I missed your comment.

Maybe we should show the desktop notification if the app is closed, but not if it's open? Will this contain an "in-app" notification when something happens? It would be the same text as the text inside the drop down, but shown right when something happens? Maybe that should be it's own issue.

@btzr-io Sorry I missed your comment. Maybe we should show the desktop notification if the app is closed, but not if it's open? Will this contain an "in-app" notification when something happens? It would be the same text as the text inside the drop down, but shown right when something happens? Maybe that should be it's own issue.

👍 1

tzarebczan commented

2019-07-03 18:20:50 +02:00

(Migrated from github.com)

Another use case now is comment notifications.

kauffj commented

2020-05-20 22:12:35 +02:00

(Migrated from github.com)

@seanyesmunt https://github.com/lbryio/internal-apis/pull/1326 will make 6 existing notifications consumable via API and make it much easier to add new ones whenever we want

Expect work to begin on this next week if we can find the time (and we probably should)

@seanyesmunt https://github.com/lbryio/internal-apis/pull/1326 will make 6 existing notifications consumable via API and make it much easier to add new ones whenever we want Expect work to begin on this next week if we can find the time (and we probably should)

kauffj commented

2020-05-25 21:42:15 +02:00

(Migrated from github.com)

@sean ensure it works as intended

kauffj commented

2020-08-24 21:18:50 +02:00

(Migrated from github.com)