ChannelThumbnail fallback broken #6955

Closed
opened 2021-08-25 10:23:23 +02:00 by infinite-persistence · 1 comment
infinite-persistence commented 2021-08-25 10:23:23 +02:00 (Migrated from github.com)

Reproduce:

Block any channel avatar URL from the Network Devtools (emulating dead URLs). The thumbnail should fallback to spaceman, and if that fails, the Gerbil.
Now, it just shows the broken thumbnail square.

Comment

Due to changes #6860 Thumbnail fixes.

It pushed the error state and setter out of ChannelThumbnail, but none of the existing clients were updated to handle it. But it also does not make sense to make each of the N clients create a state for something that was meant to be encapsulated by ChannelThumbnail.

### Reproduce: Block any channel avatar URL from the Network Devtools (emulating dead URLs). The thumbnail should fallback to spaceman, and if that fails, the Gerbil. Now, it just shows the broken thumbnail square. <img src="https://user-images.githubusercontent.com/64950861/130781732-54c11f3d-84c2-43c6-b271-ea4f4a433da4.png" width="400"> <img src="https://user-images.githubusercontent.com/64950861/130752614-3d794e67-1bdc-4300-9403-9d6e5dfe01b1.png" width="300"> ### Comment Due to changes [#6860 Thumbnail fixes](https://github.com/lbryio/lbry-desktop/pull/6860). It pushed the error state and setter out of `ChannelThumbnail`, but none of the existing clients were updated to handle it. But it also does not make sense to make each of the N clients create a state for something that was meant to be encapsulated by `ChannelThumbnail`.
tzarebczan commented 2021-08-25 16:29:41 +02:00 (Migrated from github.com)

@saltrafael can you take a look? Not sure what the right solution here is yet, but at least let's try to make it work first?

@saltrafael can you take a look? Not sure what the right solution here is yet, but at least let's try to make it work first?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LBRYCommunity/lbry-desktop#6955
No description provided.