Ignore/reset player position if video is too short or almost finished playing. #6976

Merged
Ruk33 merged 1 commit from 6948-reset-player-position-if-video-almost-done into master 2021-08-30 16:41:38 +02:00
Ruk33 commented 2021-08-27 18:00:39 +02:00 (Migrated from github.com)

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/6948

What is the current behavior?

If the video is almost done playing, when the user comes back, the position is restored and thus, the autoplay is displayed.

What is the new behavior?

The video position won't be restored if the video playing position is past 90% or the video is too short (less than 10 seconds).

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below
## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/6948 <!-- Tip: - Add keywords to directly close the Issue when the PR is merged. - Skip the keyword if the Issue contains multiple items. - https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## What is the current behavior? If the video is almost done playing, when the user comes back, the position is restored and thus, the autoplay is displayed. ## What is the new behavior? The video position won't be restored if the video playing position is past 90% or the video is too short (less than 10 seconds). ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. --> ## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> <details><summary>Toggle...</summary> What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I added a line describing my change to CHANGELOG.md - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below </details>
tzarebczan commented 2021-08-27 18:03:31 +02:00 (Migrated from github.com)

This is great, thank you! We'll get a review on it soon :)

This is great, thank you! We'll get a review on it soon :)
jessopb (Migrated from github.com) approved these changes 2021-08-29 17:49:33 +02:00
jessopb (Migrated from github.com) commented 2021-08-29 17:49:20 +02:00

I think fileInfo may be redundant here if we're passing hasFileInfo, but it's fine.

I think fileInfo may be redundant here if we're passing hasFileInfo, but it's fine.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#6976
No description provided.