Fix theater mode layout on small and medium screens

arschrier commented

2021-09-16 01:26:34 +02:00

(Migrated from github.com)

Copy link

Fixes

Fixes #6907

What is the new behavior?

Recommendations move to the bottom of the screen when the screen size is small or medium.

https://user-images.githubusercontent.com/31634995/133525600-644648b2-99aa-42c4-9fdc-6f3c4b243fc1.mp4

PR Checklist

Toggle...

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I added a line describing my change to CHANGELOG.md
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

## Fixes Fixes #6907 ## What is the new behavior? Recommendations move to the bottom of the screen when the screen size is small or medium. https://user-images.githubusercontent.com/31634995/133525600-644648b2-99aa-42c4-9fdc-6f3c4b243fc1.mp4 ## PR Checklist  <details><summary>Toggle...</summary> What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I added a line describing my change to CHANGELOG.md - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below </details>

🎉 1

jessopb (Migrated from github.com) reviewed 2021-09-16 01:26:34 +02:00

tzarebczan commented

2021-09-16 04:59:39 +02:00

(Migrated from github.com)

Copy link

Thanks again @arschrier , we'll get a review on this soon. Once it's merged, send us another email with both the recent PRs for some appreciation!

arschrier commented

2021-09-16 07:15:14 +02:00

(Migrated from github.com)

Copy link

Sounds good, thank you!

jessopb (Migrated from github.com) approved these changes 2021-09-16 17:05:45 +02:00

tzarebczan commented

2021-09-16 20:58:56 +02:00

(Migrated from github.com)

Copy link

@infinite-persistence you cool with this, or should we try to still make them show on the right hand side?

infinite-persistence commented

2021-09-17 01:46:16 +02:00

(Migrated from github.com)

Copy link

@tzarebczan, hm ... I think it's ok.
The Comments Section's Expand | Collapse button currently doesn't appear in Medium as it expects the Recommended Section to be on the right, but we can tweak that later.

@tzarebczan, hm ... I think it's ok. The Comments Section's `Expand | Collapse` button currently doesn't appear in `Medium` as it expects the Recommended Section to be on the right, but we can tweak that later.

Rows
Columns

Fix theater mode layout on small and medium screens #7108

Fixes

What is the new behavior?

PR Checklist