Fix moderator data misalignment. #7139

Merged
infinite-persistence merged 1 commit from ip/moderator.fix into master 2021-09-21 16:40:44 +02:00
infinite-persistence commented 2021-09-21 04:11:03 +02:00 (Migrated from github.com)

https://kp.odysee.com

Issue

Closes #7121 Missing mod block option (large number of moderated channels?)

Notes

It was bad to assume channelSignatures would be the same length as the promise result -- any failure in signing would cause a misalignment.

For my case, an accidentally-merged channel couldn't be signed due to a missing private key. I think it's the same for Drew.

https://kp.odysee.com ## Issue Closes [#7121 Missing mod block option (large number of moderated channels?)](https://github.com/lbryio/lbry-desktop/issues/7121) ## Notes It was bad to assume `channelSignatures` would be the same length as the promise result -- any failure in signing would cause a misalignment. For my case, an accidentally-merged channel couldn't be signed due to a missing private key. I think it's the same for Drew.
tzarebczan (Migrated from github.com) reviewed 2021-09-21 04:11:03 +02:00
infinite-persistence commented 2021-09-21 04:11:59 +02:00 (Migrated from github.com)

This still does not surface any channel-signing issues -- if the moderator account happens to encounter the private key issue, he can't block either.
Do we want to relay that error to a toast, or is that rare enough to ignore?

This still does not surface any channel-signing issues -- if the moderator account happens to encounter the private key issue, he can't block either. Do we want to relay that error to a toast, or is that rare enough to ignore?
tzarebczan commented 2021-09-21 06:55:35 +02:00 (Migrated from github.com)

Rare enough, they'll find out other ways.

Rare enough, they'll find out other ways.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#7139
No description provided.