Send video bitrate and user bandwidth to Watchman #7145

Merged

mayeaux merged 11 commits from send-bitrate-and-bandwidth-to-watchman into master

2021-10-06 20:59:34 +02:00

mayeaux commented

2021-09-21 19:42:39 +02:00

(Migrated from github.com)

Fixes issue #6891 ,

Calculates user bandwidth on analytics load, and recalculates every 30s, send both values in bits per second

Fixes issue #6891 , Calculates user bandwidth on analytics load, and recalculates every 30s, send both values in bits per second

infinite-persistence commented

2021-09-22 02:33:14 +02:00

(Migrated from github.com)

Don't forget to run lint and the auto-formatter, else it will cause unnecessary deltas for the next person touching the file :)

👍 1

tzarebczan commented

2021-09-23 03:40:35 +02:00

(Migrated from github.com)

Seems a bit overkill to re-download a file every 30 seconds to grab bandwidth. This itself can slow down their stream if their bandwidth is limited. If the file is small, it shouldn't be an issue, but it also may not be a good bandwidth test.

mayeaux commented

2021-09-23 15:33:15 +02:00

(Migrated from github.com)

Seems a bit overkill to re-download a file every 30 seconds to grab bandwidth. This itself can slow down their stream if their bandwidth is limited. If the file is small, it shouldn't be an issue, but it also may not be a good bandwidth test.

The file is 2MB, the smaller the file the less accurate the value, ideally we would serve a file from one of our own CDNs so it would more accurately match to their bandwidth, I couldn't find a file though that would be suitable (was large enough), but hopefully if we can find a large enough file (1MB+ for sure), then we can maybe change the interval speed to one minute or let me know what you think would be suitable.

> Seems a bit overkill to re-download a file every 30 seconds to grab bandwidth. This itself can slow down their stream if their bandwidth is limited. If the file is small, it shouldn't be an issue, but it also may not be a good bandwidth test. The file is 2MB, the smaller the file the less accurate the value, ideally we would serve a file from one of our own CDNs so it would more accurately match to their bandwidth, I couldn't find a file though that would be suitable (was large enough), but hopefully if we can find a large enough file (1MB+ for sure), then we can maybe change the interval speed to one minute or let me know what you think would be suitable.

tzarebczan commented

2021-09-29 17:31:46 +02:00

(Migrated from github.com)

@nikooo777 thoughts on how to deal with the bandwidth test here?

I'd say let's push with bitrate for now until we figure that out. Please fix linting and comment out the bandwidth test.

@nikooo777 thoughts on how to deal with the bandwidth test here? I'd say let's push with bitrate for now until we figure that out. Please fix linting and comment out the bandwidth test.

jessopb commented

2021-10-05 06:38:30 +02:00

(Migrated from github.com)

Blocked by deciding how often to check bandwidth?