Fix issue where channel upload viewcounts were creating a new line #7154

Merged

mayeaux merged 7 commits from improve-viewcount-display into master

2021-09-29 21:04:43 +02:00

mayeaux commented

2021-09-22 18:06:30 +02:00

(Migrated from github.com)

Fixes #7078

This address specifically 'large' view of over 1600px, where the worst offending was happening, but should also fix issues on other sizes as well, if anyone sees the view counts creating a third line on channel overview let me know and I'll take a look.

Fixes #7078 This address specifically 'large' view of over 1600px, where the worst offending was happening, but should also fix issues on other sizes as well, if anyone sees the view counts creating a third line on channel overview let me know and I'll take a look.

infinite-persistence (Migrated from github.com) reviewed 2021-09-23 04:43:08 +02:00

infinite-persistence (Migrated from github.com) left a comment

The difference in margin feels incoherent in a glance with sibling components (title). Makes it too cramped to the left side?
The channel-stake-indicator gets cut off.
Adding the tweak for specific layouts does cover most cases in English (nice), but even in other layouts it will still reflow:
Other languages still would reflow after the tweak (although I understand we are just trying to cover the most common cases):

YT does it by tweaking tile count, and ultimately just reflow.

- The difference in margin feels incoherent in a glance with sibling components (title). Makes it too cramped to the left side? - ![image](https://user-images.githubusercontent.com/64950861/134447103-e0337c6b-c173-4498-9c90-477164cb2eb9.png) - ![image](https://user-images.githubusercontent.com/64950861/134447133-26820578-c3cf-4d59-b77f-8890e7311d44.png) - The channel-stake-indicator gets cut off. - ![image](https://user-images.githubusercontent.com/64950861/134446769-0f80df3e-d070-47b6-bc1b-168993ead0ac.png) - Adding the tweak for specific layouts does cover most cases in English (nice), but even in other layouts it will still reflow: - ![image](https://user-images.githubusercontent.com/64950861/134446581-d6733255-da8a-4517-bd13-abf5323b221a.png) - Other languages still would reflow after the tweak (although I understand we are just trying to cover the most common cases): - ![image](https://user-images.githubusercontent.com/64950861/134446826-6ef35453-1ff3-45cd-b70e-d113caee0fdc.png) YT does it by tweaking tile count, and ultimately just reflow.

tzarebczan commented

2021-09-27 21:12:47 +02:00

(Migrated from github.com)

Let Anythony know linting was failing, otherwise should be good to go.

jessopb commented

2021-09-29 18:46:44 +02:00

(Migrated from github.com)

I think lint is failing because it's a new pattern, and we may not need a new pattern. @infinite-persistence can say whether this optimization is necessary for code splitting?