List own comments #7171

Merged

infinite-persistence merged 7 commits from ip/own.comments into master

2021-10-01 14:10:27 +02:00

infinite-persistence commented

2021-09-27 13:38:58 +02:00

(Migrated from github.com)

Test

KP » Settings » Account » Comments

Issue

Closes #5146 Show all own comments

Known issues

~~The total number of comments that Commentron reports vs. what it returns, can be different. Checking with Mark/Tom.~~ Fixed

## Test KP » Settings » Account » Comments ## Issue Closes [#5146 Show all own comments](https://github.com/lbryio/lbry-desktop/issues/5146) ## Known issues <strike>The total number of comments that Commentron reports vs. what it returns, can be different. Checking with Mark/Tom.</strike> Fixed

jessopb (Migrated from github.com) reviewed 2021-09-27 13:38:58 +02:00

infinite-persistence commented

2021-09-27 19:38:52 +02:00

(Migrated from github.com)

cd2f3d2 to bac26bc
Commentron now requires authorization for this action.

cd2f3d2 to bac26bc Commentron now requires authorization for this action.

tzarebczan commented

2021-09-29 17:25:13 +02:00

(Migrated from github.com)

Don't love the placement of where this is avaialble, but probably the best bet for now.

Checking with Beamer on a sorting issue, otherwise it looks good!

Don't love the placement of where this is avaialble, but probably the best bet for now. Checking with Beamer on a sorting issue, otherwise it looks good!

infinite-persistence commented

2021-09-30 09:37:01 +02:00

(Migrated from github.com)

bac26bc to 05f2aed

Add i18n strings
Rebased

bac26bc to 05f2aed - Add i18n strings - Rebased

tzarebczan commented

2021-09-30 23:13:42 +02:00

(Migrated from github.com)

There's a new sorting method (5 I think - check DMs) to remove pins.

Can we make the comment clickable or linkable?

There's a new sorting method (5 I think - check DMs) to remove pins. Can we make the comment clickable or linkable?

infinite-persistence commented

2021-10-01 10:29:25 +02:00

(Migrated from github.com)

05f2aed to 48247cb

Mobile: removed indent; reduced claim thumbnail size.
Remove automatic pinning when fetching.
Clicking on the claim (left side) now links to the comment directly. The comment (right side) remains unclickable due to:
- I find hard to copy/paste parts of the comment if the entire section is clickable.
- But I did try and couldn't get NavLink to work with Comment -- it causes lots of renders and blinking. Maybe re-visit this next time, but for now use the left-side to click?
  - Also considered adding a "View comment" button at the lower-right of each row, but that made the page busier than it is already.

05f2aed to 48247cb - Mobile: removed indent; reduced claim thumbnail size. - Remove automatic pinning when fetching. - Clicking on the claim (left side) now links to the comment directly. The comment (right side) remains unclickable due to: - I find hard to copy/paste parts of the comment if the entire section is clickable. - But I did try and couldn't get `NavLink` to work with `Comment` -- it causes lots of renders and blinking. Maybe re-visit this next time, but for now use the left-side to click? - Also considered adding a "View comment" button at the lower-right of each row, but that made the page busier than it is already.