Inconsistent thumbnail sizes in 'Trending' section #721

New issue

Closed

opened 2017-11-09 19:47:49 +01:00 by wilsonk · 6 comments

wilsonk commented

2017-11-09 19:47:49 +01:00

(Migrated from github.com)

The Issue

One can game the trending section somewhat by using a very long channel name to make the size of the thumbnail bigger than others in that section.

Steps to reproduce

1.View trending section today (Nov 9, 2017)

Expected behaviour

All thumbnails should be the same size

Actual behaviour

Thumbnails with large channel names are larger than the rest

System Configuration

LBRY Daemon version: 0.17.1
LBRY App version:0.17.1
LBRY Installation ID: 26bru4Kjp3i3VM5KTFVV3ESEkDWEb9CCA2ate4L9XJYTr8PHUK4jPDQqz4JsG73Wfr
Operating system: Linux (Linux-4.4.0-97-generic-x86_64-with-Ubuntu-16.04-xenial)

Screenshots

## The Issue One can game the trending section somewhat by using a very long channel name to make the size of the thumbnail bigger than others in that section. ### Steps to reproduce 1.View trending section today (Nov 9, 2017) ### Expected behaviour All thumbnails should be the same size ### Actual behaviour Thumbnails with large channel names are larger than the rest ## System Configuration   - LBRY Daemon version: 0.17.1 - LBRY App version:0.17.1 - LBRY Installation ID: 26bru4Kjp3i3VM5KTFVV3ESEkDWEb9CCA2ate4L9XJYTr8PHUK4jPDQqz4JsG73Wfr - Operating system: Linux (Linux-4.4.0-97-generic-x86_64-with-Ubuntu-16.04-xenial) ## Screenshots  ![screenshot_2017-11-09_11-45-19](https://user-images.githubusercontent.com/38802/32623539-bd36c6e4-c543-11e7-845e-38d2c4c83e4b.png)

wilsonk commented

2017-11-09 19:55:28 +01:00

(Migrated from github.com)

Easier to game the system this way, but with the ellipses eliding the file name size it might be easier to fix?

Sorry, maybe that isn't the channel name being too long that is the problem, but the actual size of the file name. Perhaps that forces the 'red ship/free' icon to be pushed onto the next line which then makes the thumbnail longer not wider. Easier to game the system this way, but with the ellipses eliding the file name size it might be easier to fix?

wilsonk commented

2017-11-09 20:06:28 +01:00

(Migrated from github.com)

Hmm, maybe I will eventually get this right! It actually looks like a combination of both the long file name and channel name may be the problem...??

neb-b commented

2017-11-10 10:09:51 +01:00

(Migrated from github.com)

I think we should remove the card design. It can be tough to deal with when trying to keep boxes the same height.

If we remove the card we could increase the visible text limit and not have to worry about different container heights. I think something like this redesign http://lab.zzk.fr/lbry/ would look really nice.

@liamcardenas thoughts?

I think we should remove the card design. It can be tough to deal with when trying to keep boxes the same height. If we remove the card we could increase the visible text limit and not have to worry about different container heights. I think something like this redesign http://lab.zzk.fr/lbry/ would look really nice. @liamcardenas thoughts?

👍 2

oakey22 commented

2017-11-10 11:57:52 +01:00

(Migrated from github.com)

@seanyesmunt i absolutely love that design, so professional looking

akinwale commented

2017-11-14 19:02:05 +01:00

(Migrated from github.com)

Created a PR to fix this since it kept bothering me.

Also, @seanyesmunt that new design is amazing! You should show the entire team.

Created a PR to fix this since it kept bothering me. Also, @seanyesmunt that new design is amazing! You should show the entire team.

liamcardenas commented