@hackrush01 because this is presenting each individual outpoint as a unique transaction to a user, I think it is less confusing to distribute the fee across all of the outpoints.

Consider a transaction with say, 5 outpoints. If we show the fee on each outpoint without distributing it, a user is decently likely to interpret the transaction fee as 5x as large as it actually was. I think it is better this fee is shown as 1/5 for each outpoint.

@hackrush01 because this is presenting each individual outpoint as a unique transaction to a user, I think it is less confusing to distribute the fee across all of the outpoints. Consider a transaction with say, 5 outpoints. If we show the fee on each outpoint without distributing it, a user is decently likely to interpret the transaction fee as 5x as large as it actually was. I think it is better this fee is shown as 1/5 for each outpoint.

kauffj (Migrated from github.com) requested changes 2017-11-15 22:47:50 +01:00

kauffj (Migrated from github.com) left a comment

Minor changes requested.

ui/js/selectors/wallet.js

kauffj (Migrated from github.com) commented

2017-11-15 22:45:31 +01:00

This can be combined into one if statement rather than 2.

This can be combined into one `if` statement rather than 2.

ui/js/selectors/wallet.js

kauffj (Migrated from github.com) commented

2017-11-15 22:46:31 +01:00

This is a very confusing line. Does it have to work this way? I check if I have an amount, and if I do, I use balance_delta, but if I don't, I use value?

If this is correct, perhaps something should be changed in the APIs to make this less confusing/complex.

This is a very confusing line. Does it have to work this way? I check if I have an `amount`, and if I do, I use `balance_delta`, but if I don't, I use `value`? If this is correct, perhaps something should be changed in the APIs to make this less confusing/complex.

hackrush01 commented

2017-11-17 18:58:05 +01:00

(Migrated from github.com)

@tzarebczan A few 'fee only' txns

    {
      "claim_info": [],
      "confirmations": 59523,
      "date": "2017-07-29 10:46",
      "fee": 0.000261,
      "support_info": [],
      "timestamp": 1501305377,
      "txid": "35539ad1be7d8a0d79d09817b6f14d54ecfcac156fa7bfa7c92fe3917579abbe",
      "update_info": [],
      "value": -0.000261
    },
    {
      "claim_info": [],
      "confirmations": 59512,
      "date": "2017-07-29 11:11",
      "fee": 0.000187,
      "support_info": [],
      "timestamp": 1501306881,
      "txid": "8d1fe34c62867914d9465f0f674c96987c79ebb27acd52218942b447c0ffdf59",
      "update_info": [],
      "value": -0.000187
    },
    {
      "claim_info": [],
      "confirmations": 59512,
      "date": "2017-07-29 11:11",
      "fee": 0.000187,
      "support_info": [],
      "timestamp": 1501306881,
      "txid": "fde8bd453e9f7a96a1fa66048f48e08f5a6c970d92d40e5c0f4bd370e696b3ce",
      "update_info": [],
      "value": -0.000187
    },

@tzarebczan A few 'fee only' txns ```JSON { "claim_info": [], "confirmations": 59523, "date": "2017-07-29 10:46", "fee": 0.000261, "support_info": [], "timestamp": 1501305377, "txid": "35539ad1be7d8a0d79d09817b6f14d54ecfcac156fa7bfa7c92fe3917579abbe", "update_info": [], "value": -0.000261 }, { "claim_info": [], "confirmations": 59512, "date": "2017-07-29 11:11", "fee": 0.000187, "support_info": [], "timestamp": 1501306881, "txid": "8d1fe34c62867914d9465f0f674c96987c79ebb27acd52218942b447c0ffdf59", "update_info": [], "value": -0.000187 }, { "claim_info": [], "confirmations": 59512, "date": "2017-07-29 11:11", "fee": 0.000187, "support_info": [], "timestamp": 1501306881, "txid": "fde8bd453e9f7a96a1fa66048f48e08f5a6c970d92d40e5c0f4bd370e696b3ce", "update_info": [], "value": -0.000187 }, ```

tzarebczan commented

2017-11-17 22:56:57 +01:00

(Migrated from github.com)

I'll have to check the tx ids, but do you know where those came from in terms of app actions?

hackrush01 commented

2017-11-18 15:41:45 +01:00

(Migrated from github.com)

I don't remember even a bit, these are very old transactions, and I don't
remember what I did.

On Sat, Nov 18, 2017 at 3:26 AM, Thomas Zarebczan notifications@github.com
wrote:

I'll have to check the tx ids, but do you know where those came from in
terms of app actions?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/pull/731#issuecomment-345376624, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQxPZpREC_ahpJHQyD7TX30iIYhGNypyks5s3gEqgaJpZM4QabOi
.

--
-Regards
-Amit Tulshyan

I don't remember even a bit, these are very old transactions, and I don't remember what I did. On Sat, Nov 18, 2017 at 3:26 AM, Thomas Zarebczan <notifications@github.com> wrote: > I'll have to check the tx ids, but do you know where those came from in > terms of app actions? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/pull/731#issuecomment-345376624>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AQxPZpREC_ahpJHQyD7TX30iIYhGNypyks5s3gEqgaJpZM4QabOi> > . > -- -Regards -Amit Tulshyan