LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

File info fix #735

Closed
hackrush01 wants to merge 4 commits from file_info_fix into master
pull from: file_info_fix
merge into: LBRYCommunity:master
Conversation 7 Commits 4 Files changed 8 +166 -112
hackrush01 commented 2017-11-13 19:22:32 +01:00 (Migrated from github.com)
Copy link
No description provided.
kauffj (Migrated from github.com) requested changes 2017-11-15 22:56:36 +01:00
kauffj (Migrated from github.com) left a comment
Copy link

Looks close, biggest question is if there is a slightly better way to do this that doesn't require carrying around and translating between both outpoints and sd_hashes.

Looks close, biggest question is if there is a slightly better way to do this that doesn't require carrying around and translating between both outpoints and sd_hashes.
ui/js/actions/content.js
kauffj (Migrated from github.com) commented 2017-11-15 22:55:39 +01:00
Copy link

Can this be re-written to only use sd_hash rather than both outpoint and sd_hash?

Can this be re-written to only use `sd_hash` rather than both `outpoint` and `sd_hash`?
ui/js/selectors/claims.js
kauffj (Migrated from github.com) commented 2017-11-15 22:53:53 +01:00
Copy link

Can you help me understand why this is necessary? When do I have an outpoint that I need to translated into an sd_hash? Can we just stored sd_hashes in that place instead?

Can you help me understand why this is necessary? When do I have an outpoint that I need to translated into an sd_hash? Can we just stored sd_hashes in that place instead?
kauffj (Migrated from github.com) commented 2017-11-15 22:54:02 +01:00
Copy link

ahem

*ahem*
ui/js/selectors/file_info.js
kauffj (Migrated from github.com) commented 2017-11-15 22:51:52 +01:00
Copy link

.source.source? Guessing this is correct, but please tell me who to complain to :P

`.source.source`? Guessing this is correct, but please tell me who to complain to :P
ui/js/selectors/file_info.js
kauffj (Migrated from github.com) commented 2017-11-15 22:50:04 +01:00
Copy link

sdHashes

`sdHashes`
hackrush01 (Migrated from github.com) reviewed 2017-11-17 19:27:36 +01:00
ui/js/actions/content.js
hackrush01 (Migrated from github.com) commented 2017-11-17 19:27:36 +01:00
Copy link

TL;DR I'm not sure.
It went a bit too deep inside lbry.js and it seemed to be intertwined with other stuff(such as pending publishes, dummy claims). Overwhelmed by the complications involved I couldn't muster up enough courage to mess with it.

TL;DR I'm not sure. It went a bit too deep inside `lbry.js` and it seemed to be intertwined with other stuff(such as pending publishes, dummy claims). Overwhelmed by the complications involved I couldn't muster up enough courage to mess with it.
hackrush01 (Migrated from github.com) reviewed 2017-11-17 19:29:25 +01:00
ui/js/selectors/claims.js
hackrush01 (Migrated from github.com) commented 2017-11-17 19:29:25 +01:00
Copy link

I think it is necessary due to what happens when I have a pending publish(related to https://github.com/lbryio/lbry-app/pull/735#discussion_r151756127 probably).

I think it is necessary due to what happens when I have a pending publish(related to https://github.com/lbryio/lbry-app/pull/735#discussion_r151756127 probably).
hackrush01 (Migrated from github.com) reviewed 2017-11-17 19:29:44 +01:00
ui/js/selectors/claims.js
hackrush01 (Migrated from github.com) commented 2017-11-17 19:29:44 +01:00
Copy link

Oops!

Oops!
hackrush01 (Migrated from github.com) reviewed 2017-11-17 19:31:16 +01:00
ui/js/selectors/file_info.js
hackrush01 (Migrated from github.com) commented 2017-11-17 19:31:16 +01:00
Copy link

The schema/lbryum/daemon guys.

The schema/lbryum/daemon guys.
hackrush01 (Migrated from github.com) reviewed 2017-11-17 19:31:29 +01:00
ui/js/selectors/file_info.js
hackrush01 (Migrated from github.com) commented 2017-11-17 19:31:29 +01:00
Copy link

Again, Oops!

Again, Oops!
tzarebczan commented 2017-11-20 17:51:38 +01:00 (Migrated from github.com)
Copy link

Some scenarios to test alongside these changes:
https://github.com/lbryio/lbry/issues/951
https://github.com/lbryio/lbry/issues/944
https://github.com/lbryio/lbry-app/issues/600

Some scenarios to test alongside these changes: https://github.com/lbryio/lbry/issues/951 https://github.com/lbryio/lbry/issues/944 https://github.com/lbryio/lbry-app/issues/600
kauffj commented 2017-11-24 21:09:35 +01:00 (Migrated from github.com)
Copy link

I'm not planning to merge this without reducing the amount of values carried around from 2 to 1. If sd_hash is the new key for file data instead of outpoint, let's eliminate the usage of outpoint basically everywhere.

I'm not planning to merge this without reducing the amount of values carried around from 2 to 1. If `sd_hash` is the new key for file data instead of `outpoint`, let's eliminate the usage of `outpoint` basically everywhere.
hackrush01 commented 2017-11-28 16:57:47 +01:00 (Migrated from github.com)
Copy link

I'll look into it and rebase it on master soon.

I'll look into it and rebase it on master soon.
kauffj commented 2017-11-28 17:00:35 +01:00 (Migrated from github.com)
Copy link

@hackrush01 I've actually made a bunch of progress on this separately in the flow_and_file_list branch (I used it as my test for writing code typed with Flow). I'll finish this.

@hackrush01 I've actually made a bunch of progress on this separately in the `flow_and_file_list` branch (I used it as my test for writing code typed with Flow). I'll finish this.
hackrush01 commented 2017-11-28 17:18:21 +01:00 (Migrated from github.com)
Copy link

Ok

Ok
lyoshenka commented 2017-12-12 20:01:33 +01:00 (Migrated from github.com)
Copy link

blocked by lbryio/lbry#1025

blocked by lbryio/lbry#1025
kauffj commented 2018-02-28 17:05:19 +01:00 (Migrated from github.com)
Copy link

This is no longer necessary, @liamcardenas has handled this.

This is no longer necessary, @liamcardenas has handled this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
kauffj
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#735
No description provided.
Delete branch "file_info_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?