Poor error message for no support/tip amount input #738

New issue

Closed

opened 2017-11-13 21:48:43 +01:00 by oakey22 · 8 comments

oakey22 commented

2017-11-13 21:48:43 +01:00

(Migrated from github.com)

Click support a claim and then click Send without inputting an amount, you get an error of

"Something went wrong"

This should say " Please input an amount" or something along those lines.

This is on the new 0.18.0 version

Click support a claim and then click Send without inputting an amount, you get an error of "Something went wrong" This should say " Please input an amount" or something along those lines. This is on the new 0.18.0 version ![image](https://user-images.githubusercontent.com/22527575/32748376-025edf36-c8b4-11e7-8da1-a902413e67cc.png)

tzarebczan commented

2017-11-13 22:47:09 +01:00

(Migrated from github.com)

Thanks @oakey22! Sent you a couple LBC for filing the issue.

I've run across this in the past, never got a chance to file it.

Thanks @oakey22! Sent you a couple LBC for filing the issue. I've run across this in the past, never got a chance to file it.

IGassmann commented

2017-11-22 14:03:26 +01:00

(Migrated from github.com)

This issue will be waiting for that issue. The error message should be returned by the API so it can be used in the app.

This issue will be waiting for [that issue](https://github.com/lbryio/lbry/issues/1004). The error message should be returned by the API so it can be used in the app.

liamcardenas commented

2017-12-19 07:48:52 +01:00

(Migrated from github.com)

~~@IGassmann it looks like "that issue" is done, can you get to this soon?~~ you are, as always, on top of things

~~@IGassmann it looks like "that issue" is done, can you get to this soon?~~ you are, as always, on top of things

liamcardenas commented

2017-12-19 07:49:48 +01:00

(Migrated from github.com)

oh i see this is already in "next"! nice

👍 1

IGassmann commented

2018-01-22 18:13:25 +01:00

(Migrated from github.com)

On hold until daemon next release.

tzarebczan commented

2018-04-04 22:59:47 +02:00

(Migrated from github.com)

API call now returns, is this what was expected?

{
  "error": {
    "code": -32500,
    "data": [
      "  File \"site-packages\\twisted\\internet\\defer.py\", line 1299, in _inlineCallbacks",
      "    ",
      "  File \"site-packages\\lbrynet\\daemon\\Daemon.py\", line 2719, in jsonrpc_wallet_send",
      "    ",
      "lbrynet.core.Error.NullFundsError: "
    ],
    "message": "NullFundsError"
  },
  "id": 426,
  "jsonrpc": "2.0"
}

API call now returns, is this what was expected? ``` { "error": { "code": -32500, "data": [ " File \"site-packages\\twisted\\internet\\defer.py\", line 1299, in _inlineCallbacks", " ", " File \"site-packages\\lbrynet\\daemon\\Daemon.py\", line 2719, in jsonrpc_wallet_send", " ", "lbrynet.core.Error.NullFundsError: " ], "message": "NullFundsError" }, "id": 426, "jsonrpc": "2.0" } ```

tzarebczan commented

2018-04-27 22:19:42 +02:00

(Migrated from github.com)

I think we should just disable the send box unless something is typed. @seanyesmunt can we get this done for the redesign please?

neb-b commented

2018-04-28 01:20:57 +02:00

(Migrated from github.com)

Yes