No tray icon in Arch Linux

BrunoDSL commented

2017-11-14 14:52:14 +01:00

(Migrated from github.com)

Title explains the issue.

Steps to reproduce

Install lbry-app-bin from AUR
Open LBRY

Expected behaviour

Much like every other Electron app, if the app has a tray icon, it should appear in the tray when the application opens.

Actual behaviour

No tray icon shows up. Closing the app shuts down the daemon and closes the app.

System Configuration

LBRY Daemon version: 0.18.0
LBRY App version: 0.18.0
LBRY Installation ID: 2EASrt7xbwv2k7qwJkeSDjvrTJFPV6mZ9sgHUEA25YCuHh396Jo63tkhKTjjMp12H2
Operating system: Linux (Linux-4.13.12-1-ARCH-x86_64-with-glibc2.3.4)

Anything Else

Tested using XFCE

Title explains the issue. ### Steps to reproduce 1. Install lbry-app-bin from AUR 2. Open LBRY ### Expected behaviour Much like every other Electron app, if the app has a tray icon, it should appear in the tray when the application opens. ### Actual behaviour No tray icon shows up. Closing the app shuts down the daemon and closes the app. ## System Configuration - LBRY Daemon version: 0.18.0 - LBRY App version: 0.18.0 - LBRY Installation ID: 2EASrt7xbwv2k7qwJkeSDjvrTJFPV6mZ9sgHUEA25YCuHh396Jo63tkhKTjjMp12H2 - Operating system: Linux (Linux-4.13.12-1-ARCH-x86_64-with-glibc2.3.4) ## Anything Else Tested using XFCE

tzarebczan commented

2017-11-14 18:53:18 +01:00

(Migrated from github.com)

Thanks for the issue @MR4Y ! Sent you a couple LBC on Discord for filing this, it's a good find.

hackrush01 commented

2017-11-14 19:48:33 +01:00

(Migrated from github.com)

Right now, in Linux, only Debian systems are supported.

Could you please post the output of the following command:
pacman -Qi libappindicator1. I could probably use the info to add tray
icon support in arch Linux systems.

-Regards
-Amit Tulshyan

On Nov 14, 2017 11:23 PM, "Thomas Zarebczan" notifications@github.com
wrote:

Thanks for the issue @MR4Y https://github.com/mr4y ! Sent you a couple
LBC on Discord for filing this, it's a good find.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/740#issuecomment-344341912, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQxPZhfT6deqfQHvPaz2iZB3H_TOA2gdks5s2dOQgaJpZM4QdXsW
.

Right now, in Linux, only Debian systems are supported. Could you please post the output of the following command: `pacman -Qi libappindicator1`. I could probably use the info to add tray icon support in arch Linux systems. -Regards -Amit Tulshyan On Nov 14, 2017 11:23 PM, "Thomas Zarebczan" <notifications@github.com> wrote: Thanks for the issue @MR4Y <https://github.com/mr4y> ! Sent you a couple LBC on Discord for filing this, it's a good find. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/lbryio/lbry-app/issues/740#issuecomment-344341912>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQxPZhfT6deqfQHvPaz2iZB3H_TOA2gdks5s2dOQgaJpZM4QdXsW> .

BrunoDSL commented

2017-11-14 20:25:10 +01:00

(Migrated from github.com)

Output:
error: package 'libappindicator1' was not found

Output: ```error: package 'libappindicator1' was not found```

BrunoDSL commented

2017-11-17 13:03:05 +01:00

(Migrated from github.com)

Updated lbry-app-bin to 0.18.2-1. Still no tray icon.

tzarebczan commented

2017-11-17 13:38:52 +01:00

(Migrated from github.com)

18.2 was a patch release which fixed a specific new user issue, nothing else was changed.

kauffj commented

2017-11-17 14:42:38 +01:00

(Migrated from github.com)

@MR4Y I believe Electron only supports tray icons in Linux distributions that support libappindicator1.

@MR4Y I believe Electron only supports tray icons in Linux distributions that support `libappindicator1`.

BrunoDSL commented

2017-11-25 12:03:11 +01:00

(Migrated from github.com)

Both Discord AUR buids have tray icons.

etisdew commented

2017-11-26 20:30:15 +01:00

(Migrated from github.com)

Off-topic: I would like to request any information you have regards to building to Arch for a proposal of addition to the instructions if able to resolve this. @MR4Y can we PM on discord?

BrunoDSL commented

2017-11-26 20:43:25 +01:00

(Migrated from github.com)

Yes.

etisdew commented

2017-11-26 20:49:05 +01:00

(Migrated from github.com)

@etisdew sorry, not sure which MR you are >_<

kauffj commented

2017-11-27 15:31:01 +01:00

(Migrated from github.com)

@etisdew @MR4Y as far as I know, Electron tray icons will only display if libappindiactor1 is available. See:

Can you guys clarify this issue? Is it:

You have libappindiactor1 installed, but it doesn't work.
You do not have libappindiactor1 installed, and the LBRY install process didn't try to install it.
You do not have libappindaictor1 installed, the LBRY app tried to install it, but it's not available on your system.

If it's 1, we ought to try to debug it a bit further then open with Electron. If it's 2, we can look to modify the set up process. If it's 3, I'm not sure there's much we can do.

@etisdew @MR4Y as far as I know, Electron tray icons will only display if `libappindiactor1` is available. See: - https://github.com/webtorrent/webtorrent-desktop/issues/383 - https://github.com/electron-userland/electron-builder/issues/375 Can you guys clarify this issue? Is it: 1. You have libappindiactor1 installed, but it doesn't work. 2. You do not have libappindiactor1 installed, and the LBRY install process didn't try to install it. 3. You do not have libappindaictor1 installed, the LBRY app tried to install it, but it's not available on your system. If it's 1, we ought to try to debug it a bit further then open with Electron. If it's 2, we can look to modify the set up process. If it's 3, I'm not sure there's much we can do.

hackrush01 commented

2017-11-27 16:06:15 +01:00

(Migrated from github.com)

OK so I got some time to look at the issue, and this is my diagnosis.

libappindicator1 indicator is not installed in the system (pacman -Qi libappindicator1 returned negative).
Also the app explicitly checks for libappindicator1 in Debian based
systems(https://github.com/lbryio/lbry-app/blob/master/app/main.js#L522)
We install dependencies for debian(
https://github.com/lbryio/lbry-app/blob/master/package.json#L56), which I
think would need to be changed to support arch, fedora etc. systems.
We cannot remove the check completely because other quitting
functionality depends on this. We would need to include custom checks for
different systems.

On Nov 27, 2017 8:01 PM, "Jeremy Kauffman" notifications@github.com wrote:

@etisdew https://github.com/etisdew @MR4Y https://github.com/mr4y as
far as I know, Electron tray icons will only display if libappindiactor1
is available. See:

webtorrent/webtorrent-desktop#383
https://github.com/webtorrent/webtorrent-desktop/issues/383

electron-userland/electron-builder#375
https://github.com/electron-userland/electron-builder/issues/375

Can you guys clarify this issue? Is it:

You have libappindiactor1 installed, but it doesn't work.

You do not have libappindiactor1 installed, and the LBRY install
process didn't try to install it.

You do not have libappindaictor1 installed, the LBRY app tried to
install it, but it's not available on your system.

If it's 1, we ought to try to debug it a bit further than open with
Electron. If it's 2, we can look to modify the set up process. If it's 3,
I'm not sure there's much we can do.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/740#issuecomment-347198180,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQxPZsrl5-RiVKhiqMEJmfuBb654UQ84ks5s6sengaJpZM4QdXsW
.

OK so I got some time to look at the issue, and this is my diagnosis. 1) libappindicator1 indicator is not installed in the system (`pacman -Qi libappindicator1` returned negative). 2) Also the app explicitly checks for libappindicator1 in Debian based systems(https://github.com/lbryio/lbry-app/blob/master/app/main.js#L522) 3) We install dependencies for debian( https://github.com/lbryio/lbry-app/blob/master/package.json#L56), which I think would need to be changed to support arch, fedora etc. systems. 4) We cannot remove the check completely because other quitting functionality depends on this. We would need to include custom checks for different systems. On Nov 27, 2017 8:01 PM, "Jeremy Kauffman" <notifications@github.com> wrote: > @etisdew <https://github.com/etisdew> @MR4Y <https://github.com/mr4y> as > far as I know, Electron tray icons will only display if libappindiactor1 > is available. See: > > - webtorrent/webtorrent-desktop#383 > <https://github.com/webtorrent/webtorrent-desktop/issues/383> > - electron-userland/electron-builder#375 > <https://github.com/electron-userland/electron-builder/issues/375> > > Can you guys clarify this issue? Is it: > > 1. You have libappindiactor1 installed, but it doesn't work. > 2. You do not have libappindiactor1 installed, and the LBRY install > process didn't try to install it. > 3. You do not have libappindaictor1 installed, the LBRY app tried to > install it, but it's not available on your system. > > If it's 1, we ought to try to debug it a bit further than open with > Electron. If it's 2, we can look to modify the set up process. If it's 3, > I'm not sure there's much we can do. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/740#issuecomment-347198180>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQxPZsrl5-RiVKhiqMEJmfuBb654UQ84ks5s6sengaJpZM4QdXsW> > . >

BrunoDSL commented

2017-11-28 13:02:03 +01:00

(Migrated from github.com)

@kauffj As I explained earlier all AUR builds of Discord have tray icons. None of them require libappindicator1. Discord uses libnotify instead.

johndoe01012 commented

2019-07-07 20:08:29 +02:00

(Migrated from github.com)

Trying to reproduce the issues, and it's not applied to the latest version. The tray icon is showing up as expected. I guess just close the issue, or did I miss something here?

tzarebczan commented

2019-07-07 20:11:43 +02:00

(Migrated from github.com)

Woohoo, we may have fixed it up some other icon changes we made. Closing... Thanks @vv181

No tray icon in Arch Linux #740

Steps to reproduce

Expected behaviour

Actual behaviour

System Configuration

Anything Else