Added checkbox to enable/disable background #7630

Merged
ByronEricPerez merged 4 commits from Add_a_setting_to_disable_the_background_image_#7616 into master 2022-06-28 22:01:19 +02:00
ByronEricPerez commented 2022-06-28 19:21:01 +02:00 (Migrated from github.com)

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/7616

What is the current behavior?

N/A

What is the new behavior?

image

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below
## Fixes Issue Number: https://github.com/lbryio/lbry-desktop/issues/7616 <!-- Tip: - Add keywords to directly close the Issue when the PR is merged. - Skip the keyword if the Issue contains multiple items. - https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> ## What is the current behavior? N/A ## What is the new behavior? ![image](https://user-images.githubusercontent.com/89370060/176244014-e8f6671e-eab8-4b46-92b8-4999a8e634d2.png) ## Other information <!-- If this PR contains a breaking change, please describe the impact and solution strategy for existing applications below. --> ## PR Checklist <!-- For the checkbox formatting to work properly, make sure there are no spaces on either side of the "x" --> <details><summary>Toggle...</summary> What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I added a line describing my change to CHANGELOG.md - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below </details>
jessopb (Migrated from github.com) requested changes 2022-06-28 19:39:34 +02:00
jessopb (Migrated from github.com) left a comment

This should work. Just a couple things.

This should work. Just a couple things.
jessopb (Migrated from github.com) commented 2022-06-28 19:37:08 +02:00

could call this showBackground to imply its bool type

could call this showBackground to imply its bool type
@ -3,2 +2,4 @@
import Wallpaper from './view';
import * as SETTINGS from 'constants/settings';
import { makeSelectClientSetting } from 'redux/selectors/settings';
jessopb (Migrated from github.com) commented 2022-06-28 19:38:34 +02:00

https://github.com/lbryio/lbry-desktop/blob/master/ui/redux/reducers/settings.js we've been making sure client settings have defaults

https://github.com/lbryio/lbry-desktop/blob/master/ui/redux/reducers/settings.js we've been making sure client settings have defaults
jessopb (Migrated from github.com) commented 2022-06-28 19:33:40 +02:00

is this backwards?

is this backwards?
jessopb (Migrated from github.com) approved these changes 2022-06-28 22:00:41 +02:00
jessopb (Migrated from github.com) left a comment

This is good - thanks!

This is good - thanks!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#7630
No description provided.