Fix viewer position and shape in mobile mode

jm-morani commented

2022-08-22 06:02:39 +02:00

(Migrated from github.com)

Copy link

Fixes

Issue Number:

What is the current behavior?

When the screen is narrow enough, the video is not render at the same location than the cover.
Because it's rather on the top of the window, the top of the video is hidden by the header.

What is the new behavior?

The video is played at the exact same location than the cover, and is fully visible.
As well, because that area has then no margin with the border of the window, I removed the rounded border (seems to already be a pattern).

Other information

This is a very minor change.

(On narrow window, it may look even better with an overlay scrollbar.)
Anyway, it may not be the best fix, but it solves my problem. Thank you for making lbry.

PR Checklist

Toggle...

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I added a line describing my change to CHANGELOG.md
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

## Fixes Issue Number: ## What is the current behavior? When the screen is narrow enough, the video is not render at the same location than the cover. Because it's rather on the top of the window, the top of the video is hidden by the header. ## What is the new behavior? The video is played at the exact same location than the cover, and is fully visible. As well, because that area has then no margin with the border of the window, I removed the rounded border (seems to already be a pattern). ## Other information This is a very minor change. (On narrow window, it may look even better with an overlay scrollbar.) Anyway, it may not be the best fix, but it solves my problem. Thank you for making lbry. ## PR Checklist  <details><summary>Toggle...</summary> What kind of change does this PR introduce? - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: Please check all that apply to this PR using "x": - [ ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I added a line describing my change to CHANGELOG.md - [ ] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below </details>

Fix viewer position and shape in mobile mode #7677

Fixes

What is the current behavior?

What is the new behavior?

Other information

PR Checklist