LBRYCommunity/lbry-desktop

Fork

You've already forked lbry-desktop

Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Better handling of uploaded files. #7688

Merged

Ruk33 merged 2 commits from 7687-535-upload-form-bugs into master

2022-09-19 22:42:16 +02:00

Conversation 0 Commits 2 Files changed 4 +45 -14

Ruk33 commented

2022-09-14 01:19:27 +02:00

(Migrated from github.com)

Copy link

Fixes

Issue Number:

https://github.com/lbryio/lbry-desktop/issues/7687
https://github.com/lbryio/lbry-desktop/issues/7685

What is the current behavior?

The behavior when selecting a file is different
than the behavior when it's dragged and dropped.

What is the new behavior?

The behavior when selecting a file and
dropped no longer differs.

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I added a line describing my change to CHANGELOG.md
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

## Fixes Issue Number: - https://github.com/lbryio/lbry-desktop/issues/7687 - https://github.com/lbryio/lbry-desktop/issues/7685  ## What is the current behavior? The behavior when selecting a file is different than the behavior when it's dragged and dropped. ## What is the new behavior? The behavior when selecting a file and dropped no longer differs. ## Other information  ## PR Checklist  <details><summary>Toggle...</summary> What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [ ] I added a line describing my change to CHANGELOG.md - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below </details>

jessopb (Migrated from github.com) reviewed 2022-09-16 18:34:20 +02:00

jessopb (Migrated from github.com) left a comment

Copy link

I tried this out - after selecting a transcoded video, it still says "your video may not be the best format.

ui/component/fileDrop/view.jsx

					
				@ -85,4 +83,3 @@

				            fileVid: false,

				          });

				        }, NAVIGATE_TIME_OUT);

				      }, HIDE_TIME_OUT);

jessopb (Migrated from github.com) commented

2022-09-16 18:33:59 +02:00

Copy link

The purpose of these lines was to do the math to guess Mbps and judge whether file needs to be transcoded (is a video, and size is large compared to duration). Is that done somewhere else now?

Ruk33 (Migrated from github.com) reviewed 2022-09-16 21:15:17 +02:00

ui/component/fileDrop/view.jsx

					
				@ -85,4 +83,3 @@

				            fileVid: false,

				          });

				        }, NAVIGATE_TIME_OUT);

				      }, HIDE_TIME_OUT);

Ruk33 (Migrated from github.com) commented

2022-09-16 21:15:17 +02:00

Copy link

@jessopb yes, it was removed so this logic happens only in one place (publishFile/view.jsx)

jessopb (Migrated from github.com) reviewed 2022-09-16 22:34:46 +02:00

ui/component/fileDrop/view.jsx

					
				@ -85,4 +83,3 @@

				            fileVid: false,

				          });

				        }, NAVIGATE_TIME_OUT);

				      }, HIDE_TIME_OUT);

jessopb (Migrated from github.com) commented

2022-09-16 22:34:45 +02:00

Copy link

Ok. The messaging seems wrong. Your video may not be the best format. is always the message which is the message for (isVid && !duration) so something isn't working.

Ok. The messaging seems wrong. `Your video may not be the best format.` is always the message which is the message for (isVid && !duration) so something isn't working.

jessopb (Migrated from github.com) approved these changes 2022-09-19 22:41:52 +02:00

Reviewers

No reviewers

jessopb

Labels

Clear labels

Work is part of a proposal

Beamer is waiting on you!

Discuss this issue at the next planning meeting, then remove this label

Welcome to Hacktoberfest

No knowledge of the existing code required

level: 2

Some knowledge of the existing code is recommended

level: 3

Significant knowledge of the existing code is recommended

level: 4

Intimate knowledge of the existing code is recommended

merge when green

needs: exploration

Solution unclear, needs research

needs: grooming

Issue needs to be groomed before work can start

needs: priority

Priority level needs to be defined

needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

needs: tech design

Needs technical design signoff before implementation can begin

Issue is blocking release, do ASAP

priority: high

Work needs to be moved into sprint ASAP

priority: low

Work should be done but can stay in the backlog for now

priority: medium

Work needs to be done within 2-3 sprints

protocol dependent

recsys

redesign

general redesign not prioritize for anyone release

regression

resilience

sdk dependent

Requires work on lbry-sdk repo

Tom's Wishlist

trending

type: bug

Existing functionality is wrong or broken

type: discussion

A conversation. No specific changes requested

type: improvement

Existing (or partially existing) functionality needs to be changed

type: new feature

New functionality that does not exist yet

type: refactor

Minimal user-visible changes, but significant internal work

type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

type: testing

Solution needs additional user testing

unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#7688

Reference in a new issue

Repository

LBRYCommunity/lbry-desktop

Title

Body

No description provided.

Delete branch "7687-535-upload-form-bugs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?