Quiting from the top menu bar doesn't work (File > Quit) #772

New issue

Closed

opened 2017-11-22 00:42:05 +01:00 by neb-b · 2 comments

neb-b commented

2017-11-22 00:42:05 +01:00

(Migrated from github.com)

The Issue

safeQuit is not a function

Steps to reproduce

Click "File" then "Quit" from the menu bar

Probably added here 6d01122967

@IGassmann can you look at this?

<img width="419" alt="screen shot 2017-11-21 at 6 38 25 pm" src="https://user-images.githubusercontent.com/16882830/33102594-8167dad4-ceeb-11e7-9917-08fbfd41e97f.png"> ## The Issue safeQuit is not a function ### Steps to reproduce 1. Click "File" then "Quit" from the menu bar Probably added here https://github.com/lbryio/lbry-app/commit/6d01122967169479c225201a66f9ebe675834e90 @IGassmann can you look at this?

hackrush01 commented

2017-11-22 02:29:34 +01:00

(Migrated from github.com)

I think putting module.exports in the first line would fix this issue.

-Regards
-Amit Tulshyan

On Nov 22, 2017 5:12 AM, "Sean Yesmunt" notifications@github.com wrote:

[image: screen shot 2017-11-21 at 6 38 25 pm]
https://user-images.githubusercontent.com/16882830/33102594-8167dad4-ceeb-11e7-9917-08fbfd41e97f.png
The Issue

safeQuit is not a function
Steps to reproduce

Click "File" then "Quit" from the menu bar

Probably added here 6d01122
https://github.com/lbryio/lbry-app/commit/6d01122967169479c225201a66f9ebe675834e90

@IGassmann https://github.com/igassmann can you look at this?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/772, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQxPZsqtHKEp_K1uEU7U8lrII1EMCkioks5s41_PgaJpZM4QmpzL
.

I think putting `module.exports` in the first line would fix this issue. -Regards -Amit Tulshyan On Nov 22, 2017 5:12 AM, "Sean Yesmunt" <notifications@github.com> wrote: > [image: screen shot 2017-11-21 at 6 38 25 pm] > <https://user-images.githubusercontent.com/16882830/33102594-8167dad4-ceeb-11e7-9917-08fbfd41e97f.png> > The Issue > > safeQuit is not a function > Steps to reproduce > > 1. Click "File" then "Quit" from the menu bar > > Probably added here 6d01122 > <https://github.com/lbryio/lbry-app/commit/6d01122967169479c225201a66f9ebe675834e90> > > @IGassmann <https://github.com/igassmann> can you look at this? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/772>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQxPZsqtHKEp_K1uEU7U8lrII1EMCkioks5s41_PgaJpZM4QmpzL> > . >

IGassmann commented

2017-11-22 03:34:00 +01:00

(Migrated from github.com)

@hackrush01 Yes it solves. It's because ´setMenu´ is called before the export.

I don't like that we are forced to put the export on top. There should be a better way, but for the time being, I'll put it back there.

@hackrush01 Yes it solves. It's because ´setMenu´ is called before the export. I don't like that we are forced to put the export on top. There should be a better way, but for the time being, I'll put it back there.