Channel names in pages appear highlighted #815
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#815
Loading…
Reference in a new issue
No description provided.
Delete branch "channel-name-page"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Changed overflow to
inline-flex
asinline-block
was not aligning the channel name properly in the Tipping page.Also, for line https://github.com/lbryio/lbry-app/pull/815/files#diff-e47e29116e67be706ea589295bc76bdcR76
No CSS styles exist for the different values of
modifier
. I was not sure what to do with...CSS file: https://github.com/lbryio/lbry-app/pull/815/files#diff-491c1cffd5dc21b7564acb7ca27e7252
can you use
classnames
for this?6108141605/src/renderer/js/component/address/view.jsx (L24)
@ -2,3 +2,3 @@
.channel-name {
display: inline-block;
display: inline-flex;
overflow: hidden;
👍
We can keep the
modifier
css attribute for now. I think I will be using it in my subscriptions pull requestYes, this seems awesome.
Now the channel name is also underlined providing better feedback to user.
Thinking about this some more I think we should just use the generic
<Link />
styling instead of introducing more style rules.