LBRYCommunity/lbry-desktop

Channel names in pages appear highlighted #815

Merged

hackrush01 merged 1 commit from channel-name-page into master

2017-12-06 20:09:32 +01:00

hackrush01 commented

2017-12-05 20:41:42 +01:00

(Migrated from github.com)

Changed overflow to inline-flex as inline-block was not aligning the channel name properly in the Tipping page.

Changed overflow to `inline-flex` as `inline-block` was not aligning the channel name properly in the Tipping page.

hackrush01 commented

2017-12-05 20:46:53 +01:00

(Migrated from github.com)

Also, for line https://github.com/lbryio/lbry-app/pull/815/files#diff-e47e29116e67be706ea589295bc76bdcR76
No CSS styles exist for the different values of modifier. I was not sure what to do with...
CSS file: https://github.com/lbryio/lbry-app/pull/815/files#diff-491c1cffd5dc21b7564acb7ca27e7252

Also, for line https://github.com/lbryio/lbry-app/pull/815/files#diff-e47e29116e67be706ea589295bc76bdcR76 No CSS styles exist for the different values of `modifier`. I was not sure what to do with... CSS file: https://github.com/lbryio/lbry-app/pull/815/files#diff-491c1cffd5dc21b7564acb7ca27e7252

neb-b (Migrated from github.com) requested changes

2017-12-06 16:19:30 +01:00

src/renderer/js/component/uriIndicator/view.jsx

can you use classnames for this? lbryio/lbry-app@6108141605/src/renderer/js/component/address/view.jsx (L24)

can you use `classnames` for this? https://github.com/lbryio/lbry-app/blob/610814160572a51840366eff7e604e418c58b353/src/renderer/js/component/address/view.jsx#L24

neb-b (Migrated from github.com) reviewed

2017-12-06 16:22:29 +01:00

src/renderer/scss/component/_channel-indicator.scss

					
				@ -2,3 +2,3 @@

				.channel-name {

				  display: inline-block;

				  display: inline-flex;

				  overflow: hidden;

👍

👍

neb-b commented

2017-12-06 17:39:39 +01:00

(Migrated from github.com)

We can keep the modifier css attribute for now. I think I will be using it in my subscriptions pull request

We can keep the `modifier` css attribute for now. I think I will be using it in my subscriptions pull request

hackrush01 (Migrated from github.com) reviewed

2017-12-06 17:52:57 +01:00

src/renderer/js/component/uriIndicator/view.jsx

Yes, this seems awesome.

Yes, this seems awesome.

hackrush01 commented

2017-12-06 17:58:16 +01:00

(Migrated from github.com)

Now the channel name is also underlined providing better feedback to user.

Now the channel name is also underlined providing better feedback to user.

neb-b commented

2017-12-06 18:54:01 +01:00

(Migrated from github.com)

Thinking about this some more I think we should just use the generic <Link /> styling instead of introducing more style rules.

Thinking about this some more I think we should just use the generic `<Link />` styling instead of introducing more style rules.

neb-b (Migrated from github.com) approved these changes

2017-12-06 19:51:15 +01:00

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

LBRYCommunity/lbry-desktop!815

No description provided.