Update JSON-RPC Expected Response Codes #817

New issue

Closed

opened 2017-12-05 22:20:24 +01:00 by liamcardenas · 2 comments

liamcardenas commented

2017-12-05 22:20:24 +01:00

(Migrated from github.com)

As per https://github.com/lbryio/lbry/pull/1019, JSON-RPC will return a status code 200 and errors that comply with http://www.jsonrpc.org/specification#error_object

(additionally, it uses the error class name if no error message is provided)

This may have been handled already on the app side. We need to look into it and if not we need to handle this updated response.

As per https://github.com/lbryio/lbry/pull/1019, JSON-RPC will return a status code 200 and errors that comply with http://www.jsonrpc.org/specification#error_object (additionally, it uses the error class name if no error message is provided) This may have been handled already on the app side. We need to look into it and if not we need to handle this updated response.

liamcardenas commented

2017-12-07 02:18:15 +01:00

(Migrated from github.com)

Ok, after going down a rabbit hole chasing down a the "trim" error (that nobody else other than myself gets -- as seen in the pics below), I have confirmed that this is working in the app

v18

v19rc9

As you can see, we are now expecting the new format and therefore there are lots of issues with v18. These issues are solved with v19rc9

Closing this, @kauffj @jackrobison

Ok, after going down a rabbit hole chasing down a the "trim" error (that nobody else other than myself gets -- as seen in the pics below), I have confirmed that this is working in the app v18 v19rc9 As you can see, we are now expecting the new format and therefore there are lots of issues with v18. These issues are solved with v19rc9 Closing this, @kauffj @jackrobison

kauffj commented

2017-12-07 16:22:35 +01:00

(Migrated from github.com)

@liamcardenas that trim error is real, I fixed it in branch.