Amplitude #819

2017-12-06T01:18:45+01:00

liamcardenas commented

2017-12-06 01:18:45 +01:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2017-12-06 01:29:03 +01:00

neb-b (Migrated from github.com) left a comment

Looks good, just add a comment for that weird string. If it is an api key should we be storing it somewhere else?

src/renderer/js/main.js

neb-b (Migrated from github.com) commented

2017-12-06 01:28:05 +01:00

Do you have an example of when this would fire? Just curious

src/renderer/js/main.js

					
				@ -68,3 +87,2 @@

				  function onDaemonReady() {

				    window.sessionStorage.setItem("loaded", "y"); //once we've made it here once per session, we don't need to show splash again

				    app.store.dispatch(doDaemonReady());

				    lbry.status().then(info => {

neb-b (Migrated from github.com) commented

2017-12-06 01:26:11 +01:00

what is this value?

liamcardenas (Migrated from github.com) reviewed 2017-12-06 01:30:12 +01:00

src/renderer/js/main.js

liamcardenas (Migrated from github.com) commented

2017-12-06 01:30:12 +01:00

For instance, if there is an icon with no title attribute. I put this in there so, if we see it, we can go and add a title.

liamcardenas (Migrated from github.com) reviewed 2017-12-06 01:30:24 +01:00

src/renderer/js/main.js

					
				@ -68,3 +87,2 @@

				  function onDaemonReady() {

				    window.sessionStorage.setItem("loaded", "y"); //once we've made it here once per session, we don't need to show splash again

				    app.store.dispatch(doDaemonReady());

				    lbry.status().then(info => {