Batch resolve fails if single URI encounters an error #842

New issue

Closed

opened 2017-12-11 17:31:04 +01:00 by jackrobison · 3 comments

jackrobison commented

2017-12-11 17:31:04 +01:00

(Migrated from github.com)

@tzarebczan commented on Sun Dec 10 2017

The Issue

In a batched resolution, the entire resolve command fails if one of the URLs errors out. This is happening on the homepage at the moment because of an expired claim in the resolve call.

Steps to reproduce

batch a URI resolution with a known bad URL
observe failure

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead

System Configuration

LBRY Daemon version: 0.18.2
LBRY App version: 0.19rc1
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

@jackrobison commented on Mon Dec 11 2017

resolve in lbrynet handles these cases, this error must be in the app handling of the response.

@tzarebczan commented on [Sun Dec 10 2017](https://github.com/lbryio/lbry/issues/1024)  ## The Issue In a batched resolution, the entire resolve command fails if one of the URLs errors out. This is happening on the homepage at the moment because of an expired claim in the resolve call. ### Steps to reproduce 1. batch a URI resolution with a known bad URL 2. observe failure ### Expected behaviour Tell us what should happen ### Actual behaviour Tell us what happens instead ## System Configuration   - LBRY Daemon version: 0.18.2 - LBRY App version: 0.19rc1 - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots  --- @jackrobison commented on [Mon Dec 11 2017](https://github.com/lbryio/lbry/issues/1024#issuecomment-350777582) `resolve` in lbrynet handles these cases, this error must be in the app handling of the response.

deepalimayekar commented

2018-01-04 08:49:10 +01:00

(Migrated from github.com)

In the Python file, check the statuscode of the request after the get call. If r.status_code is not 200, skip the response.

deepalimayekar commented

2018-01-04 08:51:15 +01:00

(Migrated from github.com)

import requests r = requests.get('fill url) compare r.status_code and if not 200, do not write Thus resolve will not fail if any URL is incorrect.

`import requests r = requests.get('fill url) compare r.status_code and if not 200, do not write Thus resolve will not fail if any URL is incorrect.`

lyoshenka commented

2018-04-19 17:51:21 +02:00

(Migrated from github.com)