Reworked abandon to not be depenedent on txn list #867

Merged
hackrush01 merged 1 commit from abandon-rework into master 2017-12-13 22:19:45 +01:00
hackrush01 commented 2017-12-13 19:31:47 +01:00 (Migrated from github.com)

@kauffj, so this PR removes the dependency of abandon_claim on transaction list. Now it fetches the data from myClaims instead. @tzarebczan and I have given this a whirl and so far the edge cases work too.

@kauffj, so this PR removes the dependency of abandon_claim on transaction list. Now it fetches the data from myClaims instead. @tzarebczan and I have given this a whirl and so far the edge cases work too.
kauffj (Migrated from github.com) reviewed 2017-12-13 21:48:29 +01:00
kauffj (Migrated from github.com) commented 2017-12-13 21:48:29 +01:00

And we know this is always populated because doFetchFileInfosAndPublishedClaims() is called in onDaemonReady()?

Assuming yes, LGTM and can be merged.

And we know this is always populated because `doFetchFileInfosAndPublishedClaims()` is called in `onDaemonReady()`? Assuming yes, LGTM and can be merged.
liamcardenas (Migrated from github.com) approved these changes 2017-12-13 22:09:20 +01:00
liamcardenas commented 2017-12-13 22:10:06 +01:00 (Migrated from github.com)

Code looks good, I have one question, I sent you a message on slack @hackrush01

Code looks good, I have one question, I sent you a message on slack @hackrush01
hackrush01 (Migrated from github.com) reviewed 2017-12-13 22:46:47 +01:00
hackrush01 (Migrated from github.com) commented 2017-12-13 22:46:47 +01:00

Yes, also doFetchClaimListMine() is also called at multiple important places such as after successful publish, visiting Published/Downloaded page etc. So it seems to keep updated information about claims.

Yes, also `doFetchClaimListMine()` is also called at multiple important places such as after successful publish, visiting Published/Downloaded page etc. So it seems to keep updated information about claims.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#867
No description provided.