Error when publishing with exact amount in wallet or 0 bid #874

Closed
opened 2017-12-15 16:09:34 +01:00 by tzarebczan · 2 comments
tzarebczan commented 2017-12-15 16:09:34 +01:00 (Migrated from github.com)

The Issue

There was a recent app side patch to address a deposit error when you don't have enough LBC, but it doesn't take into account the scenario if the bid is exactly equal to the wallet balance. This is most likely because there is a tx fee associated with the publish (no way to calculate this right now as it depends on what UTXOs the tx uses - this is something we'd need added to the daemon logic where the balance calculation should really reside).

image

Steps to reproduce

  1. Have 1 LBC in wallet
  2. Publish with 1 LBC bid
  3. See error

Expected behaviour

Insufficient balance error

Actual behaviour

Ugly error

System Configuration

  • LBRY Daemon version: 0.18.0
  • LBRY App version: 0..19.1
  • LBRY Installation ID:
  • Operating system: Windows

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue There was a recent app side patch to address a deposit error when you don't have enough LBC, but it doesn't take into account the scenario if the bid is exactly equal to the wallet balance. This is most likely because there is a tx fee associated with the publish (no way to calculate this right now as it depends on what UTXOs the tx uses - this is something we'd need added to the daemon logic where the balance calculation should really reside). ![image](https://user-images.githubusercontent.com/18357967/32818565-e10738cc-c978-11e7-9a0d-88f7725e2005.png) ### Steps to reproduce 1. Have 1 LBC in wallet 2. Publish with 1 LBC bid 3. See error ### Expected behaviour Insufficient balance error ### Actual behaviour Ugly error ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: 0.18.0 - LBRY App version: 0..19.1 - LBRY Installation ID: - Operating system: Windows ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
liamcardenas commented 2017-12-19 07:42:43 +01:00 (Migrated from github.com)

So the solution is to get a daemon fix, correct? I am going to mark this as protocol dependent. Otherwise, we can just arbitrarily set a limit below your balance that is the maximum you can send. i.e. max send limit is your balance - .1 LBC (or whatever the upper limit of likely fees are)

So the solution is to get a daemon fix, correct? I am going to mark this as protocol dependent. Otherwise, we can just arbitrarily set a limit below your balance that is the maximum you can send. i.e. max send limit is your balance - .1 LBC (or whatever the upper limit of likely fees are)
tzarebczan commented 2018-06-21 07:41:07 +02:00 (Migrated from github.com)

The UX around this has improved, no longer an issue in the redesign. Final adjustments will be made when the daemon can provide fee estimates.

The UX around this has improved, no longer an issue in the redesign. Final adjustments will be made when the daemon can provide fee estimates.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#874
No description provided.