Setup ESLint and Prettier and apply changes to sources #891

Merged

IGassmann merged 22 commits from issue/763 into master

2017-12-27 21:22:51 +01:00

IGassmann commented

2017-12-22 02:41:10 +01:00

(Migrated from github.com)

This configures ESLint and Prettier for the project and ensures they don't conflict with each other.

It also does:

Lint and consequently refactor all non-component source files
Pretty-print all sources
Add the commands yarn lint and yarn pretty-print
Rename command yarn dist to yarn build
Configure ESLint and Prettier to be compliant with Airbnb JavaScript Style Guide
Fix locales script
Warn if not using ES6 imports
Run Prettier and ESLint as a git hook for all staged files.

This configures ESLint and Prettier for the project and ensures they don't conflict with each other. It also does: - Lint and consequently refactor all **non-component source files** - Pretty-print all sources - Add the commands `yarn lint` and `yarn pretty-print` - Rename command `yarn dist` to `yarn build` - Configure ESLint and Prettier to be compliant with [Airbnb JavaScript Style Guide](airbnb.io/javascript/) - Fix locales script - Warn if not using ES6 imports - Run Prettier and ESLint as a git hook for all staged files.

liamcardenas (Migrated from github.com) reviewed 2017-12-26 19:30:17 +01:00

liamcardenas (Migrated from github.com) left a comment

Wow massive! this looks great. I'm not sure it's possible to code review every line here, instead maybe we should merge and do comprehensive testing to make sure everything still works. Thoughts @kauffj?

IGassmann commented

2017-12-26 21:22:08 +01:00

(Migrated from github.com)

I've done some sanity testing on Windows and macOS.

kauffj commented

2017-12-26 23:54:43 +01:00

(Migrated from github.com)

@liamcardenas I'm fine with this. @IGassmann are there any particular areas of concern?

IGassmann commented

2017-12-27 00:00:15 +01:00

(Migrated from github.com)

I've done some refactoring in pretty much all files with the exception of components files. With the tests, I identified (and fixed) only one bug due to my changes.