Use fee estimator to show estimated fee on spend confirm screen #903

Open
opened 2017-12-27 21:07:50 +01:00 by tzarebczan · 2 comments
tzarebczan commented 2017-12-27 21:07:50 +01:00 (Migrated from github.com)

The Issue

If a user tries to send their entire LBC balance to an address (not taking into account tx fees), they are presented with the "get credits" modal and the LBC is not sent. We should mention that transaction fees are associated with sending credits. I'm not sure if we have a way to estimate what those fees are right now (it depends on how many UTXOs are part of of the tx), but we should at least have a better message.

Once we do have the fees, we should have a button called "send max" which takes into account the tx fees.

Steps to reproduce

  1. Send entire LBC balance
  2. Get message about credits

System Configuration

  • LBRY Daemon version: 0.18.0
  • LBRY App version: 0.19.2
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on live chat at https://chat.lbry.io --> ## The Issue If a user tries to send their entire LBC balance to an address (not taking into account tx fees), they are presented with the "get credits" modal and the LBC is not sent. We should mention that transaction fees are associated with sending credits. I'm not sure if we have a way to estimate what those fees are right now (it depends on how many UTXOs are part of of the tx), but we should at least have a better message. Once we do have the fees, we should have a button called "send max" which takes into account the tx fees. ### Steps to reproduce 1. Send entire LBC balance 2. Get message about credits ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: 0.18.0 - LBRY App version: 0.19.2 - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
liamcardenas commented 2018-01-02 06:17:37 +01:00 (Migrated from github.com)

This happened to me the other day, we definitely should fix this asap imo

This happened to me the other day, we definitely should fix this asap imo
tzarebczan commented 2018-02-02 23:43:24 +01:00 (Migrated from github.com)

@liamcardenas adding this to the user wishlist. We should at least show a better error if sending an amount greater than the wallet balance, but in the end, this (https://github.com/lbryio/lbry/issues/1045) may be required.

@liamcardenas adding this to the user wishlist. We should at least show a better error if sending an amount greater than the wallet balance, but in the end, this (https://github.com/lbryio/lbry/issues/1045) may be required.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#903
No description provided.