Re-introduce build dir / dist dir option for isolated build environments. #933

Merged

JoshStrobl merged 1 commit from readd-builddir into master

2018-01-09 15:24:57 +01:00

JoshStrobl commented

2018-01-09 01:06:58 +01:00

(Migrated from github.com)

This PR re-introduces the functionality for building lbry-app with a directory target. This is important for isolated build environments like solbuild (used for Solus), where build and install directories are different (and the contents of install dir are used in a final binary package) and thus necessitate being able to have unpackaged assets be placed in a directory relative to the build location, so instructions may be performed on those assets.

Note: This patch has already been tested with this commit to our package repo and validated locally.

This PR re-introduces the functionality for building lbry-app with a directory target. This is important for isolated build environments like [solbuild](https://github.com/solus-project/solbuild) (used for Solus), where build and install directories are different (and the contents of install dir are used in a final binary package) and thus necessitate being able to have unpackaged assets be placed in a directory relative to the build location, so instructions may be performed on those assets. Note: This patch has already been tested with [this commit to our package repo](https://dev.solus-project.com/R3654:0770e2ea0a5b5e9305cb988a0b089ddd785c4e06) and validated locally.

IGassmann (Migrated from github.com) approved these changes 2018-01-09 15:24:34 +01:00

IGassmann commented

2018-01-09 15:27:19 +01:00

(Migrated from github.com)

@JoshStrobl Thanks for your contribution! Check out this for redeeming a reward.

kauffj commented

2018-01-09 17:39:48 +01:00

(Migrated from github.com)

@IGassmann it helps if you actually include the link 😛 https://lbry.io/faq/tips

But @JoshStrobl is a LBRY pro by now so I suspect he already knows he can get a reward for this. Thank you Josh!

@IGassmann it helps if you actually include the link :stuck_out_tongue: https://lbry.io/faq/tips But @JoshStrobl is a LBRY pro by now so I suspect he already knows he can get a reward for this. Thank you Josh!

😆 1

JoshStrobl commented

2018-01-09 22:14:56 +01:00

(Migrated from github.com)

Thanks for the quick review and merge @IGassmann. In terms of rewards, I'll pass (but it is appreciated). The patch was admittedly mostly self-serving, helps simplify the packaging process for the lbry-app on Solus and enables me to get it into the hands of users faster 😄