App Navigation and Wallet pages groundwork #936

2018-01-09T03:18:36+01:00

neb-b commented

2018-01-09 03:18:36 +01:00

(Migrated from github.com)

A lot of files but most are small JSX/css changes and Flow additions

Focus:
Add side nav/improve header (search)
Use Feather Icons (needs standarization)
Sub-link navigation (subheader reworked)
Home page cleanup
Wallet Pages (Basic stuff. I'll go more in depth later, just getting stuff looking kinda ok)
Added flow to a lot of components (going to add it to more redux stuff in another pr)

A lot of files but most are small JSX/css changes and Flow additions Focus: Add side nav/improve header (search) Use Feather Icons (needs standarization) Sub-link navigation (subheader reworked) Home page cleanup Wallet Pages (Basic stuff. I'll go more in depth later, just getting stuff looking kinda ok) Added flow to a lot of components (going to add it to more redux stuff in another pr)

kauffj (Migrated from github.com) reviewed 2018-01-09 03:18:36 +01:00

neb-b (Migrated from github.com) reviewed 2018-01-22 06:27:00 +01:00

src/main/index.js

neb-b (Migrated from github.com) commented

2018-01-22 06:27:00 +01:00

This is preventing a draggable window. Should be a simple fix but definitely getting rid of the title bar. Need to explore how it looks on window/linux though

neb-b (Migrated from github.com) reviewed 2018-01-22 06:31:10 +01:00

src/renderer/component/shapeShift/internal/form.jsx

					
				@ -49,23 +47,27 @@ export default (props: Props) => {

				  } = props;

				  return (

neb-b (Migrated from github.com) commented

2018-01-22 06:31:10 +01:00

I think I'm going to change this to FormElement and keep FormRow which just allows several FormElements side by side

I think I'm going to change this to `FormElement` and keep `FormRow` which just allows several `FormElement`s side by side

neb-b (Migrated from github.com) reviewed 2018-01-22 22:12:05 +01:00

src/renderer/component/address/view.jsx

					
				@ -14,1 +12,4 @@

				export default class Address extends React.PureComponent<Props> {

				  constructor() {

				    super();

neb-b (Migrated from github.com) commented

2018-01-22 22:12:05 +01:00

Using render props makes it really simple add additional items to the form field like this button. Instead of having a huge FormField element that can do everything, allowing the user of the component to do whatever they want can be really nice.

Using render props makes it really simple add additional items to the form field like this button. Instead of having a huge `FormField` element that can do everything, allowing the user of the component to do whatever they want can be really nice.

neb-b (Migrated from github.com) reviewed 2018-01-22 22:18:09 +01:00

src/renderer/component/common/form.jsx

neb-b (Migrated from github.com) commented

2018-01-22 22:18:09 +01:00

Using render and children are really similar. Maybe we should just choose one and use it everywhere. The additional feature that render gives you is that you can pass state/computed values into the render function and allow consuming components to interact with it in a more customizable way.

Using `render` and `children` are really similar. Maybe we should just choose one and use it everywhere. The additional feature that `render` gives you is that you can pass state/computed values into the render function and allow consuming components to interact with it in a more customizable way.

neb-b (Migrated from github.com) reviewed 2018-01-22 22:24:16 +01:00

src/renderer/component/form/index.js

neb-b (Migrated from github.com) commented

2018-01-22 22:24:16 +01:00

This will be removed

neb-b (Migrated from github.com) reviewed 2018-01-22 22:35:20 +01:00

src/renderer/component/menu.js

neb-b (Migrated from github.com) commented

2018-01-22 22:35:20 +01:00

This wasn't being used anywhere

neb-b (Migrated from github.com) reviewed 2018-01-22 22:54:36 +01:00

src/renderer/constants/icons.js

					
				@ -2,2 +1,3 @@

				export const LOCAL = 'folder';

				export const FEATURED = 'Award';

				export const LOCAL = 'Folder';

				export const FILE = 'file';

neb-b (Migrated from github.com) commented

2018-01-22 22:54:36 +01:00

Going to add every icon to this file and only change every Icon use to constants

neb-b (Migrated from github.com) reviewed 2018-01-24 08:44:12 +01:00

src/renderer/constants/icons.js

					
				@ -2,2 +1,3 @@

				export const LOCAL = 'folder';

				export const FEATURED = 'Award';

				export const LOCAL = 'Folder';

				export const FILE = 'file';

neb-b (Migrated from github.com) commented

2018-01-24 08:44:12 +01:00

at a later time

* at a later time

liamcardenas (Migrated from github.com) requested changes 2018-01-24 17:38:26 +01:00

liamcardenas (Migrated from github.com) left a comment

wow this is massive! this is my first go through... i havent run the code yet. I will check it out and then see if i have any more comments

npm-debug.log.3540228334

liamcardenas (Migrated from github.com) commented

2018-01-24 17:27:00 +01:00

should this be git ignored?

src/renderer/component/uriIndicator/view.jsx

					
				@ -5,3 +5,3 @@

				import classnames from 'classnames';

				import Icon from 'component/common/icon';

				// import Icon from 'component/common/icon';

liamcardenas (Migrated from github.com) commented

2018-01-24 17:33:23 +01:00

i assume you will remove the commented code here and elsewhere before we merge

src/renderer/constants/icons.js

					
				@ -2,2 +1,3 @@

				export const LOCAL = 'folder';

				export const FEATURED = 'Award';

				export const LOCAL = 'Folder';

				export const FILE = 'file';

liamcardenas (Migrated from github.com) commented

2018-01-24 17:35:43 +01:00

is there a reason why the ones you just added are upper case but the others are lower?

neb-b commented

2018-01-24 19:51:36 +01:00

(Migrated from github.com)

@liamcardenas Not sure why I can't respond to your comment about icons. The old icons used lowercase. This new module react-feather uses uppercase. One of the reasons I want to use constants for all of them.

@liamcardenas Not sure why I can't respond to your comment about icons. The old icons used lowercase. This new module `react-feather` uses uppercase. One of the reasons I want to use constants for all of them.

neb-b (Migrated from github.com) reviewed 2018-01-24 19:52:04 +01:00

npm-debug.log.3540228334

neb-b (Migrated from github.com) commented

2018-01-24 19:52:04 +01:00

yes

neb-b (Migrated from github.com) reviewed 2018-01-24 19:52:59 +01:00

src/renderer/component/uriIndicator/view.jsx

					
				@ -5,3 +5,3 @@

				import classnames from 'classnames';

				import Icon from 'component/common/icon';

				// import Icon from 'component/common/icon';

neb-b (Migrated from github.com) commented

2018-01-24 19:52:58 +01:00

I wasn't planning on it. Mostly they are just reminders to come back to something. I'm not sure if I need to keep this, but I will know when I start on the File Page (next)

liamcardenas commented

2018-01-24 20:48:06 +01:00

(Migrated from github.com)

@seanyesmunt makes sense!

liamcardenas (Migrated from github.com) reviewed 2018-01-24 20:48:21 +01:00

src/renderer/component/uriIndicator/view.jsx

					
				@ -5,3 +5,3 @@

				import classnames from 'classnames';

				import Icon from 'component/common/icon';

				// import Icon from 'component/common/icon';