Inconsistent modal header appearance #940

Closed
opened 2018-01-09 21:38:01 +01:00 by kauffj · 1 comment
kauffj commented 2018-01-09 21:38:01 +01:00 (Migrated from github.com)

@alexliebowitz correctly pointed out that we're inconsistent with our modal stylings.

I think many (most? all?) modals look better with spacing below the header when they have a header. However, several modals that have spacing just inject a <br/>, which is probably wrong.

@seanyesmunt please add this to design epic if it makes sense to include this in that.

@alexliebowitz correctly [pointed out](https://github.com/lbryio/lbry-app/pull/808#discussion_r160289340) that we're inconsistent with our modal stylings. I think many (most? all?) modals look better with spacing below the header when they have a header. However, several modals that have spacing just inject a `<br/>`, which is probably wrong. @seanyesmunt please add this to design epic if it makes sense to include this in that.
neb-b commented 2018-01-09 21:54:18 +01:00 (Migrated from github.com)

👍 ill spend some time exploring this

On Jan 9, 2018 12:38 PM, "Jeremy Kauffman" notifications@github.com wrote:

@alexliebowitz https://github.com/alexliebowitz correctly pointed out
https://github.com/lbryio/lbry-app/pull/808#discussion_r160289340 that
we're inconsistent with our modal stylings.

I think many (most? all?) modals look better with spacing below the header
when they have a header. However, several modals that have spacing just
inject a
, which is probably wrong.

@seanyesmunt https://github.com/seanyesmunt please add this to design
epic if it makes sense to include this in that.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/940, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGcjgYCSjYPPOR7JaavokC8L9YUZIrMks5tI84tgaJpZM4RYaDy
.

👍 ill spend some time exploring this On Jan 9, 2018 12:38 PM, "Jeremy Kauffman" <notifications@github.com> wrote: > @alexliebowitz <https://github.com/alexliebowitz> correctly pointed out > <https://github.com/lbryio/lbry-app/pull/808#discussion_r160289340> that > we're inconsistent with our modal stylings. > > I think many (most? all?) modals look better with spacing below the header > when they have a header. However, several modals that have spacing just > inject a <br/>, which is probably wrong. > > @seanyesmunt <https://github.com/seanyesmunt> please add this to design > epic if it makes sense to include this in that. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/940>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQGcjgYCSjYPPOR7JaavokC8L9YUZIrMks5tI84tgaJpZM4RYaDy> > . >
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
LBRYCommunity/lbry-desktop#940
No description provided.