Feature request: network settings #949

New issue

Open

opened 2018-01-15 23:43:46 +01:00 by Technophant · 8 comments

Technophant commented

2018-01-15 23:43:46 +01:00

(Migrated from github.com)

In addition to having a visual network status indicator (#603), there needs to be network settings similar to what is found in other peer2peer clients.

Some things that should be included:
connection_status: code & message
blocks_behind, if zero then return up-to-date
startup_status
toggle use_pnp
set peer_port
simple port status check (open or closed)
set random port option
set proxy port
be able to set upload and download bandwidth limits (upload is more important)
bandwidth test and auto-set upload bandwidth perhpas
be able to change reflector server

In addition to having a visual network status indicator (#603), there needs to be network settings similar to what is found in other peer2peer clients. Some things that should be included: connection_status: code & message blocks_behind, if zero then return up-to-date startup_status toggle use_pnp set peer_port simple port status check (open or closed) set random port option set proxy port be able to set upload and download bandwidth limits (upload is more important) bandwidth test and auto-set upload bandwidth perhpas be able to change reflector server

👍 2

tzarebczan commented

2018-01-17 20:04:21 +01:00

(Migrated from github.com)

Also, I'm not sure we want to expose all of these settings to the users, at least not without going into some "advanced configuration" menu - i.e a typical (or even advanced user) would not know what a reflector server is or what options to set.

Feel free to explore a bit more and then edit your original issue as needed.

Thanks again for the contribution, please see https://lbry.io/faq/tips

@Technophant thanks for creating this issue! A few of the items you mentioned already have separate issues open on the daemon side - https://github.com/lbryio/lbry/issues/1002 (proxy), https://github.com/lbryio/lbry/issues/798 (BW limits), https://github.com/lbryio/lbry/issues/934 (port check) Also, I'm not sure we want to expose all of these settings to the users, at least not without going into some "advanced configuration" menu - i.e a typical (or even advanced user) would not know what a reflector server is or what options to set. Feel free to explore a bit more and then edit your original issue as needed. Thanks again for the contribution, please see https://lbry.io/faq/tips

kauffj commented

2018-01-17 23:11:04 +01:00

(Migrated from github.com)

@tzarebczan I think it makes sense to add a simple UI for settings like peer_port and use_upnp, which already exist via settings_set.

@Technophant let me know if you're interested in working on any of these ;) But thanks for opening either way!

@tzarebczan I think it makes sense to add a simple UI for settings like `peer_port` and `use_upnp`, which already exist via `settings_set`. @Technophant let me know if you're interested in working on any of these ;) But thanks for opening either way!

Technophant commented

2018-01-30 05:32:10 +01:00

(Migrated from github.com)

I'm busy with other things, but yes those two options would be easy to add to the UI and would pretty much take care of my concerns except for the upload bandwidth it takes up. I have a decent cable connection, however I needed to close it because it was causing me issues. 1 Mbit up and down with daemon running but nothing requested.

ahmedkrmn commented

2019-10-06 12:44:20 +02:00

(Migrated from github.com)

Can I work on this?

tzarebczan commented

2019-10-10 20:30:33 +02:00

(Migrated from github.com)

@ahmedkrmn , it's all yours! Some of the settings do require a full restart of the app+sdk, so we would have to make that option available as part of this effort.

The ones I think we should focus on are:

use_upnp
peer_port
udp_port

@ahmedkrmn , it's all yours! Some of the settings do require a full restart of the app+sdk, so we would have to make that option available as part of this effort. The ones I think we should focus on are: use_upnp peer_port udp_port

ahmedkrmn commented

2019-10-11 15:46:22 +02:00

(Migrated from github.com)

Hey @tzarebczan, I can't find the function definition of Lbry.settings_set() in either lbry-desktop or lbry-redux.

Hey @tzarebczan, I can't find the function definition of [`Lbry.settings_set()`](https://github.com/lbryio/lbry-desktop/blob/fcaf0ec0fced75b75aa5d055faa2af5125b0d0a8/src/ui/redux/actions/settings.js#L26) in either [lbry-desktop](https://github.com/lbryio/lbry-desktop) or [lbry-redux](https://github.com/lbryio/lbry-redux).

kauffj commented

2019-10-15 00:06:44 +02:00

(Migrated from github.com)

@ahmedkrmn all Lbry.xxx() API calls are simple pass-throughs to this API: https://lbry.tech/api/sdk

@ahmedkrmn all `Lbry.xxx()` API calls are simple pass-throughs to this API: https://lbry.tech/api/sdk

trymeouteh commented

2022-08-02 19:42:39 +02:00

(Migrated from github.com)

Here are some suggestions also

https://github.com/lbryio/lbry-desktop/issues/7657

https://github.com/lbryio/lbry-desktop/issues/7658

Here are some suggestions also https://github.com/lbryio/lbry-desktop/issues/7657 https://github.com/lbryio/lbry-desktop/issues/7658