Refactor Lbryuri.js #952

Closed
opened 2018-01-18 03:50:51 +01:00 by IGassmann · 4 comments
IGassmann commented 2018-01-18 03:50:51 +01:00 (Migrated from github.com)
No description provided.
kauffj commented 2018-01-18 15:37:22 +01:00 (Migrated from github.com)

Can you elaborate @IGassmann?

Can you elaborate @IGassmann?
IGassmann commented 2018-01-18 15:41:38 +01:00 (Migrated from github.com)

This is already mostly done. I opened this issue for remembering me to PR it.

I've refactored the file taking into account this recommendation.

This is already mostly done. I opened this issue for remembering me to PR it. I've refactored the file taking into account [this recommendation](https://github.com/airbnb/javascript/issues/1687#issuecomment-355098956).
kauffj commented 2018-01-18 19:25:23 +01:00 (Migrated from github.com)

The recommendation is that each function be it's own module? That seems kind of absurd to me...

The recommendation is that each function be it's own module? That seems kind of absurd to me...
IGassmann commented 2018-01-18 19:32:11 +01:00 (Migrated from github.com)

I went for exporting independently each function from the same same file. It makes more sense.

I went for exporting independently each function from the same same file. It makes more sense.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#952
No description provided.