prefer wallet_unused_address over wallet_new_address #98

2017-04-27T20:19:32+02:00

lyoshenka commented

2017-04-27 20:19:32 +02:00

(Migrated from github.com)

did i do this right?

kauffj (Migrated from github.com) reviewed 2017-04-27 20:19:32 +02:00

alexliebowitz (Migrated from github.com) reviewed 2017-04-27 20:19:32 +02:00

lyoshenka (Migrated from github.com) reviewed 2017-04-27 20:20:05 +02:00

ui/js/page/wallet.js

					
				@ -18,3 +18,3 @@

				      });

				    });

				    }.bind(this));

				  },

lyoshenka (Migrated from github.com) commented

2017-04-27 20:20:05 +02:00

why did the one below have bind(this) but this one didnt?

why did the one below have `bind(this)` but this one didnt?

kauffj (Migrated from github.com) reviewed 2017-04-27 23:00:45 +02:00

ui/js/page/wallet.js

					
				@ -18,3 +18,3 @@

				      });

				    });

				    }.bind(this));

				  },

kauffj (Migrated from github.com) commented

2017-04-27 23:00:45 +02:00

Because it doesn't use an arrow function and thus loses the scope of this otherwise. Wherever you see .bind(this) it can probably be re-written as an arrow function.

Because it doesn't use an arrow function and thus loses the scope of `this` otherwise. Wherever you see `.bind(this)` it can probably be re-written as an arrow function.

lyoshenka (Migrated from github.com) reviewed 2017-04-28 20:46:25 +02:00

ui/js/page/wallet.js

					
				@ -18,3 +18,3 @@

				      });

				    });

				    }.bind(this));

				  },

lyoshenka (Migrated from github.com) commented

2017-04-28 20:46:25 +02:00

I did not realized that arrow functions work differently from normal functions. I assumed that was just the new way of writing them (like array() vs [])

I did not realized that arrow functions work differently from normal functions. I assumed that was just the new way of writing them (like `array()` vs `[]`)

Sign in to join this conversation.

No reviewers

alexliebowitz

kauffj