LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

.pkg format for macos (bounty, 20000 LBC) #99

Closed
Wast-3 wants to merge 4 commits from master into master
pull from: master
merge into: LBRYCommunity:master
Conversation 8 Commits 4 Files changed 10 +80 -23
Wast-3 commented 2017-04-27 20:38:12 +02:00 (Migrated from github.com)
Copy link

Changes the electron-build script to automatically build to .pkg if being compiled on a mac.
Introduces a script for creating a .pkg if on linux.

Changes the electron-build script to automatically build to .pkg if being compiled on a mac. Introduces a script for creating a .pkg if on linux.
jackrobison (Migrated from github.com) reviewed 2017-04-28 17:37:24 +02:00
build/PackageInfo.xml
jackrobison (Migrated from github.com) commented 2017-04-28 17:37:24 +02:00
Copy link

what does auth="root" do?

what does `auth="root"` do?
jackrobison (Migrated from github.com) reviewed 2017-04-28 17:38:30 +02:00
build/PackageInfo.xml
jackrobison (Migrated from github.com) commented 2017-04-28 17:38:30 +02:00
Copy link

Can these be moved to env variables?

Can these be moved to env variables?
jackrobison (Migrated from github.com) reviewed 2017-04-28 17:39:27 +02:00
build/PackageInfo.xml
jackrobison (Migrated from github.com) commented 2017-04-28 17:39:27 +02:00
Copy link

The release script will have to be updated to bump the version here

The release script will have to be updated to bump the version here
Wast-3 (Migrated from github.com) reviewed 2017-04-28 17:47:26 +02:00
build/PackageInfo.xml
Wast-3 (Migrated from github.com) commented 2017-04-28 17:47:26 +02:00
Copy link

Defines if the user needs to authenticate as an admin user to install the package

Defines if the user needs to authenticate as an admin user to install the package
Wast-3 (Migrated from github.com) reviewed 2017-04-28 18:59:12 +02:00
build/PackageInfo.xml
Wast-3 (Migrated from github.com) commented 2017-04-28 18:59:12 +02:00
Copy link

I don't think so but I'm sure I can figure something out with sed.

I don't think so but I'm sure I can figure something out with sed.
lyoshenka (Migrated from github.com) reviewed 2017-04-29 18:01:29 +02:00
lyoshenka (Migrated from github.com) left a comment
Copy link

thanks for your help on this. ill look at this again on monday and probably merge it in

thanks for your help on this. ill look at this again on monday and probably merge it in
build/PackageInfo.xml
lyoshenka (Migrated from github.com) commented 2017-04-29 17:59:50 +02:00
Copy link

how did you calculate the number of files and the installation size? we can't have this hardcoded, since it will need to change anytime we make code changes

how did you calculate the number of files and the installation size? we can't have this hardcoded, since it will need to change anytime we make code changes
lyoshenka (Migrated from github.com) commented 2017-04-29 18:00:16 +02:00
Copy link

is it possible to install this without asking for root?

is it possible to install this without asking for root?
package.json
@ -67,0 +11,4 @@
"target": "pkg"
},
"linux": {
"target": "deb"
lyoshenka (Migrated from github.com) commented 2017-04-29 18:01:00 +02:00
Copy link

is the icon still included in this build? or do .pkg builds not have an icon?

is the icon still included in this build? or do .pkg builds not have an icon?
Wast-3 (Migrated from github.com) reviewed 2017-04-29 22:24:29 +02:00
build/PackageInfo.xml
Wast-3 (Migrated from github.com) commented 2017-04-29 22:24:29 +02:00
Copy link

I believe the /Applications/ directory always requires root access, so no.

I believe the /Applications/ directory always requires root access, so no.
Wast-3 (Migrated from github.com) reviewed 2017-04-29 22:27:56 +02:00
build/PackageInfo.xml
Wast-3 (Migrated from github.com) commented 2017-04-29 22:27:56 +02:00
Copy link

find root | wc -l < if executed in the .pkg directory will show the number of files and

du -b -s root < will give the number of bytes (needs to be converted to kbytes)

find root | wc -l < if executed in the .pkg directory will show the number of files and du -b -s root < will give the number of bytes (needs to be converted to kbytes)
Wast-3 commented 2017-05-01 22:34:42 +02:00 (Migrated from github.com)
Copy link

Dependencies:

  • https://github.com/hogliux/bomutils: Creates apples's BOM file (bill of materials) which gets turned into a receipt that you can use to uninstall the app. This file contains a manifest of everything the package will install and where to

  • http://xmlstar.sourceforge.net/: Used to modify .xml files. When I was trying to use sed, it would break .xml files for some reason.

  • https://github.com/mackyle/xar: .pkg files are actually .xar archives, this utility is needed in the final step to create the .pkg

Dependencies: - [https://github.com/hogliux/bomutils](bomutils): Creates apples's BOM file (bill of materials) which gets turned into a receipt that you can use to uninstall the app. This file contains a manifest of everything the package will install and where to - [http://xmlstar.sourceforge.net/](xmlstarlet): Used to modify .xml files. When I was trying to use sed, it would break .xml files for some reason. - [https://github.com/mackyle/xar](eXtensibleARchiver): .pkg files are actually .xar archives, this utility is needed in the final step to create the .pkg
lyoshenka commented 2017-05-01 23:11:35 +02:00 (Migrated from github.com)
Copy link

I know I said I'd look at this today, but I didn't get to it. Sorry. It's the first thing on my list tomorrow.

I know I said I'd look at this today, but I didn't get to it. Sorry. It's the first thing on my list tomorrow.
Wast-3 commented 2017-05-01 23:32:10 +02:00 (Migrated from github.com)
Copy link

Don't worry about it.

Don't worry about it.
Wast-3 (Migrated from github.com) reviewed 2017-05-02 17:27:18 +02:00
package.json
@ -67,0 +11,4 @@
"target": "pkg"
},
"linux": {
"target": "deb"
Wast-3 (Migrated from github.com) commented 2017-05-02 17:27:18 +02:00
Copy link

As far as I can tell, without using xcode there is no way to use an icon for the .pkg

As far as I can tell, without using xcode there is no way to use an icon for the .pkg
jackrobison commented 2017-05-03 15:56:51 +02:00 (Migrated from github.com)
Copy link

A couple small things:

  • build dependancies should be installed by build/build.sh

  • build/PackageInfo.xml and build/Distribution.xml (versions, file counts, size of built app) should be updated by build/build.sh so it doesn't have to be done manually

  • please remove flat/base.pkg/Payload, build/daemon.zip, flat/Distrubution, flat/base.pkg/Bom, and flat/base.pkg/PackageInfo

A couple small things: - build dependancies should be installed by `build/build.sh` - `build/PackageInfo.xml` and `build/Distribution.xml` (versions, file counts, size of built app) should be updated by `build/build.sh` so it doesn't have to be done manually - please remove `flat/base.pkg/Payload`, `build/daemon.zip`, `flat/Distrubution`, `flat/base.pkg/Bom`, and `flat/base.pkg/PackageInfo`
Wast-3 commented 2017-05-03 20:25:54 +02:00 (Migrated from github.com)
Copy link

I have work so I won't be able to work on these until later tonight but I'll get it done.

I have work so I won't be able to work on these until later tonight but I'll get it done.
lyoshenka commented 2017-05-31 19:51:16 +02:00 (Migrated from github.com)
Copy link

More discussion about dmg vs pkg here: https://github.com/lbryio/lbry/issues/589

More discussion about dmg vs pkg here: https://github.com/lbryio/lbry/issues/589
lyoshenka commented 2017-05-31 19:51:23 +02:00 (Migrated from github.com)
Copy link

@ChristianBeach any chance you can finish this?

@ChristianBeach any chance you can finish this?
lyoshenka commented 2017-06-06 15:33:33 +02:00 (Migrated from github.com)
Copy link

Closing this for now. @ChristianBeach please reopen when you make the changes Jack mentioned.

Closing this for now. @ChristianBeach please reopen when you make the changes Jack mentioned.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#99
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?