feature: ModalSocialShare #1943
|
@ -4,9 +4,14 @@ import { clipboard } from 'electron';
|
||||||
import { FormRow } from 'component/common/form';
|
import { FormRow } from 'component/common/form';
|
||||||
import Button from 'component/button';
|
import Button from 'component/button';
|
||||||
import * as icons from 'constants/icons';
|
import * as icons from 'constants/icons';
|
||||||
|
/*
|
||||||
|
noSnackbar added due to issue 1945
|
||||||
|
https://github.com/lbryio/lbry-desktop/issues/1945
|
||||||
|
"Snackbars and modals can't be displayed at the same time"
|
||||||
|
*/
|
||||||
type Props = {
|
type Props = {
|
||||||
address: string,
|
address: string,
|
||||||
|
noSnackbar: boolean,
|
||||||
doNotify: ({ message: string, displayType: Array<string> }) => void,
|
doNotify: ({ message: string, displayType: Array<string> }) => void,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
@ -20,7 +25,7 @@ export default class Address extends React.PureComponent<Props> {
|
||||||
input: ?HTMLInputElement;
|
input: ?HTMLInputElement;
|
||||||
|
|
||||||
render() {
|
render() {
|
||||||
const { address, doNotify } = this.props;
|
const { address, doNotify, noSnackbar } = this.props;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<FormRow verticallyCentered padded stretch>
|
<FormRow verticallyCentered padded stretch>
|
||||||
|
@ -43,10 +48,12 @@ export default class Address extends React.PureComponent<Props> {
|
||||||
icon={icons.CLIPBOARD}
|
icon={icons.CLIPBOARD}
|
||||||
onClick={() => {
|
onClick={() => {
|
||||||
clipboard.writeText(address);
|
clipboard.writeText(address);
|
||||||
doNotify({
|
if (!noSnackbar) {
|
||||||
message: __('Address copied'),
|
doNotify({
|
||||||
displayType: ['snackbar'],
|
message: __('Address copied'),
|
||||||
});
|
displayType: ['snackbar'],
|
||||||
|
});
|
||||||
|
}
|
||||||
}}
|
}}
|
||||||
/>
|
/>
|
||||||
</FormRow>
|
</FormRow>
|
||||||
|
|
|
@ -8,6 +8,7 @@ import Tooltip from 'component/common/tooltip';
|
||||||
// These are copied from `scss/vars`, can they both come from the same source?
|
// These are copied from `scss/vars`, can they both come from the same source?
|
||||||
const RED_COLOR = '#e2495e';
|
const RED_COLOR = '#e2495e';
|
||||||
const GREEN_COLOR = '#44b098';
|
const GREEN_COLOR = '#44b098';
|
||||||
|
const BLUE_COLOR = '#49b2e2';
|
||||||
|
|
||||||
type Props = {
|
type Props = {
|
||||||
icon: string,
|
icon: string,
|
||||||
|
@ -33,6 +34,8 @@ class IconComponent extends React.PureComponent<Props> {
|
||||||
return RED_COLOR;
|
return RED_COLOR;
|
||||||
case 'green':
|
case 'green':
|
||||||
return GREEN_COLOR;
|
return GREEN_COLOR;
|
||||||
|
case 'blue':
|
||||||
|
return BLUE_COLOR;
|
||||||
default:
|
default:
|
||||||
return undefined;
|
return undefined;
|
||||||
}
|
}
|
||||||
|
|
9
src/renderer/component/socialShare/index.js
Normal file
|
@ -0,0 +1,9 @@
|
||||||
|
import { connect } from 'react-redux';
|
||||||
|
import { makeSelectClaimForUri } from 'lbry-redux';
|
||||||
|
import SocialShare from './view';
|
||||||
|
|
||||||
|
const select = (state, props) => ({
|
||||||
|
claim: makeSelectClaimForUri(props.uri)(state),
|
||||||
|
});
|
||||||
|
|
||||||
|
export default connect(select)(SocialShare);
|
77
src/renderer/component/socialShare/view.jsx
Normal file
|
@ -0,0 +1,77 @@
|
||||||
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
// @flow
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
import React from 'react';
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
import type { Claim } from 'types/claim';
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
import Button from 'component/button';
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
import * as icons from 'constants/icons';
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
import Tooltip from 'component/common/tooltip';
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
import Address from 'component/address';
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
type Props = {
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
claim: Claim,
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
onDone: () => void,
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
};
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
class SocialShare extends React.PureComponent<Props> {
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
constructor(props: Props) {
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
super(props);
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
this.input = undefined;
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
input: ?HTMLInputElement;
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
render() {
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
const { claim_id: claimId, name: claimName, channel_name: channelName } = this.props.claim;
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
const { onDone } = this.props;
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
const speechPrefix = 'http://spee.ch/';
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
const speechURL = channelName
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
? `${speechPrefix}${channelName}/${claimName}`
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
: `${speechPrefix}${claimName}#${claimId}`;
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
return (
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<div>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<div className="card__title">
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<h2>{__('Share This Content')}</h2>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<div className="card__content">
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<Address address={speechURL} noSnackbar />
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
</div>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<div className="card__actions card__actions--center">
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<Tooltip onComponent body={__('Facebook')}>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<Button
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
iconColor="blue"
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
icon={icons.FACEBOOK}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
button="alt"
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
label={__('')}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
href={`https://facebook.com/sharer/sharer.php?u=${speechURL}`}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
/>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
</Tooltip>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<Tooltip onComponent body={__('Twitter')}>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<Button
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
iconColor="blue"
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
icon={icons.TWITTER}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
button="alt"
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
label={__('')}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
href={`https://twitter.com/home?status=${speechURL}`}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
/>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
</Tooltip>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<Tooltip onComponent body={__('View on Spee.ch')}>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<Button
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
icon={icons.GLOBE}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
iconColor="blue"
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
button="alt"
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
label={__('')}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
href={`${speechURL}`}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
/>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
</Tooltip>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
</div>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<div className="card__actions">
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
<Button button="link" label={__('Done')} onClick={onDone} />
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
</div>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
</div>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
</div>
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
);
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
}
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|||||||
|
export default SocialShare;
|
||||||
Since the above code is pretty much identical to the Maybe I'm only talking about everything inside of the Since the above code is pretty much identical to the `Address` component at `component/address/view.jsx` we should probably break this into it's own component.
Maybe `CopyableInput`?
I'm only talking about everything inside of the `FormRow`. It would just need two props (I think), `value` and `copySuccessMessage` (for the snackbar after you copy it)
I don't think we need google plus, especially since we don't have an icon for it. I don't think we need google plus, especially since we don't have an icon for it.
This should be This should be `card__actions`. It should give the buttons proper spacing.
I originally tried to use If so, taking doNotify functionality out of Address and making it an optional passed prop might be best? I originally tried to use `<Address />` and it crashed at that point. Using `<Address />` now has the odd behavior that it doesn't show the snackbar until after the modal is closed (modal over modal?). I will need to really look into how doNotify on top of doNotify works. Perhaps it's putting the next notification in a queue that doesn't get activated until my modal is closed?
If so, taking doNotify functionality out of Address and making it an optional passed prop might be best?
Ah you are right. I forgot about that. I just created an issue for it. I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it. We should probably rename the Ah you are right. I forgot about that. I just created an issue for it.
https://github.com/lbryio/lbry-desktop/issues/1945
I'm fine with passing in a prop for now to disable this (it should default to notify) for now. Just include a link to this issue #1945 in a comment above it.
We should probably rename the `Address` component if we are going to use it here.
|
|
@ -30,3 +30,5 @@ export const EXTERNAL_LINK = 'ExternalLink';
|
||||||
export const GIFT = 'Gift';
|
export const GIFT = 'Gift';
|
||||||
export const EYE = 'Eye';
|
export const EYE = 'Eye';
|
||||||
export const PLAY = 'Play';
|
export const PLAY = 'Play';
|
||||||
|
export const FACEBOOK = 'Facebook';
|
||||||
|
export const TWITTER = 'Twitter';
|
||||||
|
|
|
@ -19,9 +19,10 @@ import ModalEmailCollection from 'modal/modalEmailCollection';
|
||||||
import ModalPhoneCollection from 'modal/modalPhoneCollection';
|
import ModalPhoneCollection from 'modal/modalPhoneCollection';
|
||||||
import ModalFirstSubscription from 'modal/modalFirstSubscription';
|
import ModalFirstSubscription from 'modal/modalFirstSubscription';
|
||||||
import ModalConfirmTransaction from 'modal/modalConfirmTransaction';
|
import ModalConfirmTransaction from 'modal/modalConfirmTransaction';
|
||||||
import ModalSendTip from '../modalSendTip';
|
import ModalSocialShare from 'modal/modalSocialShare';
|
||||||
import ModalPublish from '../modalPublish';
|
import ModalSendTip from 'modal/modalSendTip';
|
||||||
import ModalOpenExternalLink from '../modalOpenExternalLink';
|
import ModalPublish from 'modal/modalPublish';
|
||||||
|
import ModalOpenExternalLink from 'modal/modalOpenExternalLink';
|
||||||
import ModalConfirmThumbnailUpload from 'modal/modalConfirmThumbnailUpload';
|
import ModalConfirmThumbnailUpload from 'modal/modalConfirmThumbnailUpload';
|
||||||
import ModalWalletEncrypt from 'modal/modalWalletEncrypt';
|
import ModalWalletEncrypt from 'modal/modalWalletEncrypt';
|
||||||
import ModalWalletDecrypt from 'modal/modalWalletDecrypt';
|
import ModalWalletDecrypt from 'modal/modalWalletDecrypt';
|
||||||
|
@ -160,6 +161,8 @@ class ModalRouter extends React.PureComponent<Props> {
|
||||||
return <ModalFirstSubscription {...notificationProps} />;
|
return <ModalFirstSubscription {...notificationProps} />;
|
||||||
case MODALS.SEND_TIP:
|
case MODALS.SEND_TIP:
|
||||||
return <ModalSendTip {...notificationProps} />;
|
return <ModalSendTip {...notificationProps} />;
|
||||||
|
case MODALS.SOCIAL_SHARE:
|
||||||
|
return <ModalSocialShare {...notificationProps} />;
|
||||||
case MODALS.PUBLISH:
|
case MODALS.PUBLISH:
|
||||||
return <ModalPublish {...notificationProps} />;
|
return <ModalPublish {...notificationProps} />;
|
||||||
case MODALS.CONFIRM_EXTERNAL_LINK:
|
case MODALS.CONFIRM_EXTERNAL_LINK:
|
||||||
|
|
12
src/renderer/modal/modalSocialShare/index.js
Normal file
|
@ -0,0 +1,12 @@
|
||||||
|
import { connect } from 'react-redux';
|
||||||
|
import { doHideNotification } from 'lbry-redux';
|
||||||
|
import ModalSocialShare from './view';
|
||||||
|
|
||||||
|
const perform = dispatch => ({
|
||||||
|
closeModal: () => dispatch(doHideNotification()),
|
||||||
|
});
|
||||||
|
|
||||||
|
export default connect(
|
||||||
|
null,
|
||||||
|
perform
|
||||||
|
)(ModalSocialShare);
|
22
src/renderer/modal/modalSocialShare/view.jsx
Normal file
|
@ -0,0 +1,22 @@
|
||||||
|
// @flow
|
||||||
|
import React from 'react';
|
||||||
|
import { Modal } from 'modal/modal';
|
||||||
|
import SocialShare from 'component/socialShare';
|
||||||
|
|
||||||
|
type Props = {
|
||||||
|
closeModal: () => void,
|
||||||
|
uri: string,
|
||||||
|
};
|
||||||
|
|
||||||
|
class ModalSocialShare extends React.PureComponent<Props> {
|
||||||
|
render() {
|
||||||
|
const { closeModal, uri } = this.props;
|
||||||
|
return (
|
||||||
|
<Modal isOpen onAborted={closeModal} type="custom">
|
||||||
|
<SocialShare uri={uri} onDone={closeModal} />
|
||||||
|
</Modal>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
export default ModalSocialShare;
|
|
@ -13,7 +13,6 @@ import DateTime from 'component/dateTime';
|
||||||
import * as icons from 'constants/icons';
|
import * as icons from 'constants/icons';
|
||||||
import Button from 'component/button';
|
import Button from 'component/button';
|
||||||
import SubscribeButton from 'component/subscribeButton';
|
import SubscribeButton from 'component/subscribeButton';
|
||||||
import ViewOnWebButton from 'component/viewOnWebButton';
|
|
||||||
import Page from 'component/page';
|
import Page from 'component/page';
|
||||||
import type { Claim } from 'types/claim';
|
import type { Claim } from 'types/claim';
|
||||||
import type { Subscription } from 'types/subscription';
|
import type { Subscription } from 'types/subscription';
|
||||||
|
@ -224,7 +223,12 @@ class FilePage extends React.Component<Props> {
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
{speechSharable && (
|
{speechSharable && (
|
||||||
<ViewOnWebButton claimId={claim.claim_id} claimName={claim.name} />
|
<Button
|
||||||
|
button="alt"
|
||||||
|
icon={icons.GLOBE}
|
||||||
|
label={__('Share')}
|
||||||
|
onClick={() => openModal({ id: MODALS.SOCIAL_SHARE }, { uri })}
|
||||||
|
/>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
|
Since the above code is pretty much identical to the
Address
component atcomponent/address/view.jsx
we should probably break this into it's own component.Maybe
CopyableInput
?I'm only talking about everything inside of the
FormRow
. It would just need two props (I think),value
andcopySuccessMessage
(for the snackbar after you copy it)I don't think we need google plus, especially since we don't have an icon for it.
This should be
card__actions
. It should give the buttons proper spacing.