Smart tooltip #1979

Merged
btzr-io merged 4 commits from tooltip into master 2018-09-25 02:43:08 +02:00
3 changed files with 70 additions and 7 deletions

View file

@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
* Allow typing of encryption password without clicking entry box ([#1977](https://github.com/lbryio/lbry-desktop/pull/1977))
### Changed
* Make tooltip smarter ([#1979](https://github.com/lbryio/lbry-desktop/pull/1979))
### Fixed

View file

@ -16,8 +16,67 @@ class ToolTip extends React.PureComponent<Props> {
direction: 'bottom',
};
constructor(props) {
super(props);
this.tooltip = React.createRef();
this.state = {
direction: this.props.direction,
};
}
componentDidMount() {
this.handleVisibility();
}
getVisibility = () => {
const node = this.tooltip.current;
const rect = node.getBoundingClientRect();
// Get parent-container
const viewport = document.getElementById('content');
const visibility = {
top: rect.top >= 0,
left: rect.left >= 0,
right: rect.right <= viewport.offsetWidth,
bottom: rect.bottom <= viewport.offsetHeight,
};
return visibility;
};
invertDirection = () => {
// Get current direction
const { direction } = this.state;
// Inverted directions
const directions = {
top: 'bottom',
left: 'right',
right: 'left',
bottom: 'top',
};
const inverted = directions[direction];
// Update direction
if (inverted) {
this.setState({ direction: inverted });
}
};
handleVisibility = () => {
const { direction } = this.state;
const visibility = this.getVisibility();
// Invert direction if tooltip is outside viewport bounds
if (!visibility[direction]) {
neb-b commented 2018-09-24 21:09:09 +02:00 (Migrated from github.com)
Review

Could you add a short comment above this explaining why we might need to invert? The code is very readable but it wouldn't hurt to add some additional explanation.

Could you add a short comment above this explaining why we might need to invert? The code is very readable but it wouldn't hurt to add some additional explanation.
this.invertDirection();
}
};
render() {
const { children, label, body, icon, direction, onComponent } = this.props;
const { direction } = this.state;
const { children, label, body, icon, onComponent } = this.props;
const tooltipContent = children || label;
const bodyLength = body.length;
@ -25,6 +84,8 @@ class ToolTip extends React.PureComponent<Props> {
return (
<span
onFocus={this.handleVisibility}
onMouseOver={this.handleVisibility}
className={classnames('tooltip', {
'tooltip--label': label && !icon,
'tooltip--icon': icon,
@ -37,6 +98,7 @@ class ToolTip extends React.PureComponent<Props> {
>
{tooltipContent}
<span
ref={this.tooltip}
className={classnames('tooltip__body', {
'tooltip__body--short': isShortDescription,
})}

View file

@ -63,13 +63,13 @@
&.tooltip__body--short {
margin-left: -65px;
}
}
&::after {
top: 100%;
left: 50%;
margin-left: -5px;
border-color: var(--tooltip-bg) transparent transparent transparent;
&::after {
top: 100%;
left: 50%;
margin-left: -5px;
border-color: var(--tooltip-bg) transparent transparent transparent;
}
}
}