RC fixes #2473

Merged
neb-b merged 26 commits from fixes into master 2019-05-14 20:22:04 +02:00
3 changed files with 61 additions and 15 deletions
Showing only changes of commit c1aa7609ba - Show all commits

Binary file not shown.

After

Width:  |  Height:  |  Size: 4.6 KiB

View file

@ -1,15 +1,44 @@
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
// @flow
import React from 'react';
import { parseURI } from 'lbry-redux';
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
import classnames from 'classnames';
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
import Gerbil from './gerbil.png';
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
type Props = {
thumbnail: ?string,
uri: string,
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
};
function ChannelThumbnail(props: Props) {
const { thumbnail } = props;
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
const { thumbnail, uri } = props;
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
function getColorClass() {
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
// Generate a random color class based on the first letter of the channel name
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
const { channelName } = parseURI(uri);
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
const initializer = channelName.charCodeAt(0) - 65; // will be between 0 and 57
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
let thumbnailColorClass = `channel-thumbnail__default--`;
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
switch (true) {
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
case initializer < 15:
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
return (thumbnailColorClass += '1');
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
case initializer < 30:
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
return (thumbnailColorClass += '2');
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
case initializer < 45:
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
return (thumbnailColorClass += '3');
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
default:
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
return (thumbnailColorClass += '4');
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
}
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
}
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
return (
<div className="channel__thumbnail">
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
{thumbnail && <img className="channel__thumbnail--custom" src={thumbnail} />}
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
<div
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
className={classnames('channel-thumbnail', {
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
[getColorClass()]: !thumbnail,
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
})}
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
>
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
{!thumbnail && <img className="channel-thumbnail__default" src={Gerbil} />}
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
{thumbnail && <img className="channel-thumbnail__custom" src={thumbnail} />}
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
</div>
);
}

kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`
kauffj commented 2019-05-14 00:21:04 +02:00 (Migrated from github.com)
Review

I believe that thumbnailColorClass += (initializer % 15) or something close to this is equivalent to the entire switch

I believe that `thumbnailColorClass += (initializer % 15)` or something close to this is equivalent to the entire `switch`
neb-b commented 2019-05-14 07:20:54 +02:00 (Migrated from github.com)
Review

Yep. initializer % 4

Yep. `initializer % 4`

View file

@ -14,7 +14,7 @@ $metadata-z-index: 1;
align-self: flex-start;
position: absolute;
object-fit: cover;
filter: brightness(40%);
filter: brightness(60%);
}
.channel__cover,
@ -23,27 +23,48 @@ $metadata-z-index: 1;
width: 100%;
}
.channel__thumbnail {
.channel-thumbnail {
position: absolute;
display: flex;
left: var(--spacing-main-padding);
height: var(--channel-thumbnail-size);
width: var(--channel-thumbnail-size);
background-color: $lbry-gray-3;
background-image: linear-gradient(to right, $lbry-white, $lbry-gray-3 80%);
background-size: cover;
box-shadow: 0px 8px 40px -3px $lbry-black;
}
.channel__thumbnail--custom {
.channel-thumbnail__custom {
width: 100%;
object-fit: cover;
}
.channel__thumbnail,
.channel__thumbnail--custom {
.channel-thumbnail__default {
width: 80%;
height: 80%;
margin-left: auto;
margin-right: auto;
align-self: flex-end;
margin-bottom: -1px;
}
.channel-thumbnail,
.channel-thumbnail__custom {
border-radius: var(--card-radius);
}
.channel-thumbnail__default--1 {
background-color: $lbry-indigo-3;
}
.channel-thumbnail__default--2 {
background-color: $lbry-orange-2;
}
.channel-thumbnail__default--3 {
background-color: $lbry-blue-3;
}
.channel-thumbnail__default--4 {
background-color: $lbry-red-1;
}
.channel__primary-info {
// Ensure the profile pic/title sit ontop of the default cover background
z-index: $metadata-z-index;
@ -63,9 +84,5 @@ $metadata-z-index: 1;
font-size: 1.2rem;
user-select: all;
margin-top: -0.25rem;
color: rgba($lbry-white, 0.75);
}
// .channel__description {
// font-size: 1.3rem;
// margin: var(--spacing-vertical-large) 0;
// }