Thumbnail slider #2492

Merged
zxawry merged 1 commit from thumbnail-slider into master 2019-05-22 00:00:30 +02:00
7 changed files with 135 additions and 6 deletions

View file

@ -407,6 +407,7 @@ class PublishForm extends React.PureComponent<Props> {
</header> </header>
<SelectThumbnail <SelectThumbnail
filePath={filePath}
thumbnailPath={thumbnailPath} thumbnailPath={thumbnailPath}
thumbnail={thumbnail} thumbnail={thumbnail}
uploadThumbnailStatus={uploadThumbnailStatus} uploadThumbnailStatus={uploadThumbnailStatus}

View file

@ -2,6 +2,7 @@
import * as MODALS from 'constants/modal_types'; import * as MODALS from 'constants/modal_types';
import { THUMBNAIL_STATUSES } from 'lbry-redux'; import { THUMBNAIL_STATUSES } from 'lbry-redux';
import * as React from 'react'; import * as React from 'react';
import getMediaType from 'util/get-media-type';
import { FormField } from 'component/common/form'; import { FormField } from 'component/common/form';
import FileSelector from 'component/common/file-selector'; import FileSelector from 'component/common/file-selector';
import Button from 'component/button'; import Button from 'component/button';
@ -9,6 +10,7 @@ import ThumbnailMissingImage from './thumbnail-missing.png';
import ThumbnailBrokenImage from './thumbnail-broken.png'; import ThumbnailBrokenImage from './thumbnail-broken.png';
type Props = { type Props = {
filePath: ?string,
thumbnail: ?string, thumbnail: ?string,
formDisabled: boolean, formDisabled: boolean,
uploadThumbnailStatus: string, uploadThumbnailStatus: string,
@ -50,6 +52,7 @@ class SelectThumbnail extends React.PureComponent<Props, State> {
render() { render() {
const { const {
filePath,
thumbnail, thumbnail,
formDisabled, formDisabled,
uploadThumbnailStatus: status, uploadThumbnailStatus: status,
@ -61,6 +64,8 @@ class SelectThumbnail extends React.PureComponent<Props, State> {
const { thumbnailError } = this.state; const { thumbnailError } = this.state;
const isSupportedVideo = getMediaType(null, filePath) === 'video';
let thumbnailSrc; let thumbnailSrc;
if (!thumbnail) { if (!thumbnail) {
thumbnailSrc = ThumbnailMissingImage; thumbnailSrc = ThumbnailMissingImage;
@ -141,9 +146,16 @@ class SelectThumbnail extends React.PureComponent<Props, State> {
<div className="card__actions"> <div className="card__actions">
<Button <Button
button="link" button="link"
label={__('Or enter a URL manually')} label={__('Enter a thumbnail URL')}
onClick={() => updatePublishForm({ uploadThumbnailStatus: THUMBNAIL_STATUSES.MANUAL })} onClick={() => updatePublishForm({ uploadThumbnailStatus: THUMBNAIL_STATUSES.MANUAL })}
/> />
{isSupportedVideo && (
<Button
button="link"
label={__('Take a snapshot from your video')}
onClick={() => openModal(MODALS.AUTO_GENERATE_THUMBNAIL, { filePath })}
/>
)}
</div> </div>
)} )}

View file

@ -3,6 +3,7 @@ export const CONFIRM_EXTERNAL_RESOURCE = 'confirm_external_resource';
export const INCOMPATIBLE_DAEMON = 'incompatible_daemon'; export const INCOMPATIBLE_DAEMON = 'incompatible_daemon';
export const FILE_TIMEOUT = 'file_timeout'; export const FILE_TIMEOUT = 'file_timeout';
export const DOWNLOADING = 'downloading'; export const DOWNLOADING = 'downloading';
export const AUTO_GENERATE_THUMBNAIL = 'auto_generate_thumbnail';
export const AUTO_UPDATE_DOWNLOADED = 'auto_update_downloaded'; export const AUTO_UPDATE_DOWNLOADED = 'auto_update_downloaded';
export const AUTO_UPDATE_CONFIRM = 'auto_update_confirm'; export const AUTO_UPDATE_CONFIRM = 'auto_update_confirm';
export const ERROR = 'error'; export const ERROR = 'error';

View file

@ -0,0 +1,16 @@
import { connect } from 'react-redux';
import { doHideModal } from 'redux/actions/app';
import { doUploadThumbnail } from 'redux/actions/publish';
import { doToast } from 'lbry-redux';
import ModalAutoGenerateThumbnail from './view';
const perform = dispatch => ({
closeModal: () => dispatch(doHideModal()),
upload: buffer => dispatch(doUploadThumbnail(null, buffer)),
showToast: options => dispatch(doToast(options)),
});
export default connect(
null,
perform
)(ModalAutoGenerateThumbnail);

View file

@ -0,0 +1,84 @@
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
// @flow
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
import React, { useRef } from 'react';
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
import { Modal } from 'modal/modal';
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
type Props = {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
upload: Buffer => void,
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
filePath: string,
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
closeModal: () => void,
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
showToast: ({}) => void,
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
};
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
function ModalAutoGenerateThumbnail(props: Props) {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const { closeModal, filePath, upload, showToast } = props;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const playerRef = useRef();
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
let src = filePath.replace(/\\/g, '/');
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
src = src[0] !== '/' ? `/${src}` : src;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
src = encodeURI(`file://${src}`).replace(/[?#]/g, encodeURIComponent);
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
function uploadImage() {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const imageBuffer = captureSnapshot();
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
if (imageBuffer) {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
upload(imageBuffer);
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
closeModal();
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
} else {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
onError();
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
function captureSnapshot(): ?Buffer {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const player = playerRef.current;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
if (!player) {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
return;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const canvas = document.createElement('canvas');
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
canvas.width = player.videoWidth;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
canvas.height = player.videoHeight;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const context = canvas.getContext('2d');
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
context.drawImage(player, 0, 0, canvas.width, canvas.height);
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const dataURL = canvas.toDataURL();
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const rawData = dataURL.replace(/data:image\/\w+;base64,/i, '');
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
canvas.remove();
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
return Buffer.from(rawData, 'base64');
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
function resize(): void {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const player = playerRef.current;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
if (!player) {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
return;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
console.log('resized');
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const fixedWidth = 450;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const videoWidth = player.videoWidth;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
const videoHeight = player.videoHeight;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
player.width = fixedWidth;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
player.height = Math.floor(videoHeight * (fixedWidth / videoWidth));
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
function onError(): void {
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
showToast({ isError: true, message: __("Something didn't work. Please try again.") });
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
return (
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
<Modal
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
isOpen
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
title={__('Upload Thumbnail')}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
contentLabel={__('Confirm Thumbnail Upload')}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
type="confirm"
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
confirmButtonLabel={__('Upload')}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
onConfirmed={uploadImage}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
onAborted={closeModal}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
>
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
<section className="card__content">
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
<p className="card__subtitle">{__('Pause at any time to select a thumbnail from your video')}.</p>
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
<video ref={playerRef} src={src} onLoadedMetadata={resize} onError={onError} controls />
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
</section>
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
</Modal>
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
);
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
}
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)
export default ModalAutoGenerateThumbnail;
neb-b commented 2019-05-20 04:55:23 +02:00 (Migrated from github.com)
Review

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."

We don't need to mention spee.ch. Let's just say `"Pause at any time to select a thumbnail from your video."
neb-b commented 2019-05-20 04:55:39 +02:00 (Migrated from github.com)
Review

This should be <p className="card__subtitle">

This should be `<p className="card__subtitle">`
neb-b commented 2019-05-20 04:56:27 +02:00 (Migrated from github.com)
Review

This should be a ref instead of accessing the dom by ID.

This should be a `ref` instead of accessing the dom by ID.
neb-b commented 2019-05-20 05:02:35 +02:00 (Migrated from github.com)
Review

We can use the ref here too.

We can use the ref here too.
zxawry commented 2019-05-20 14:04:37 +02:00 (Migrated from github.com)
Review

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.

I tried to use string refs but react docs says it's legacy and will be deprecated, so I added a ref property in the constructor, which led to some flow type errors I couldn't fix.
neb-b commented 2019-05-20 19:31:23 +02:00 (Migrated from github.com)
Review

Refs aren't being deprecated. What you added looks good.

Refs aren't being deprecated. What you added looks good.
zxawry commented 2019-05-20 19:59:19 +02:00 (Migrated from github.com)
Review

I mean string refs here

I mean string refs [here](https://reactjs.org/docs/refs-and-the-dom.html#legacy-api-string-refs)

View file

@ -4,6 +4,7 @@ import * as MODALS from 'constants/modal_types';
import ModalError from 'modal/modalError'; import ModalError from 'modal/modalError';
import ModalAuthFailure from 'modal/modalAuthFailure'; import ModalAuthFailure from 'modal/modalAuthFailure';
import ModalDownloading from 'modal/modalDownloading'; import ModalDownloading from 'modal/modalDownloading';
import ModalAutoGenerateThumbnail from 'modal/modalAutoGenerateThumbnail';
import ModalAutoUpdateDownloaded from 'modal/modalAutoUpdateDownloaded'; import ModalAutoUpdateDownloaded from 'modal/modalAutoUpdateDownloaded';
import ModalAutoUpdateConfirm from 'modal/modalAutoUpdateConfirm'; import ModalAutoUpdateConfirm from 'modal/modalAutoUpdateConfirm';
import ModalUpgrade from 'modal/modalUpgrade'; import ModalUpgrade from 'modal/modalUpgrade';
@ -51,6 +52,8 @@ function ModalRouter(props: Props) {
return <ModalUpgrade {...modalProps} />; return <ModalUpgrade {...modalProps} />;
case MODALS.DOWNLOADING: case MODALS.DOWNLOADING:
return <ModalDownloading {...modalProps} />; return <ModalDownloading {...modalProps} />;
case MODALS.AUTO_GENERATE_THUMBNAIL:
return <ModalAutoGenerateThumbnail {...modalProps} />;
case MODALS.AUTO_UPDATE_DOWNLOADED: case MODALS.AUTO_UPDATE_DOWNLOADED:
return <ModalAutoUpdateDownloaded {...modalProps} />; return <ModalAutoUpdateDownloaded {...modalProps} />;
case MODALS.AUTO_UPDATE_CONFIRM: case MODALS.AUTO_UPDATE_CONFIRM:

View file

@ -68,10 +68,22 @@ export const doUpdatePublishForm = (publishFormValue: UpdatePublishFormData) =>
data: { ...publishFormValue }, data: { ...publishFormValue },
neb-b commented 2019-05-20 05:02:18 +02:00 (Migrated from github.com)
Review

We shouldn't need to do this because we've declared that filePath will be a string. Maybe we should add a second argument for a buffer?

export const doUploadThumbnail = (filePath?: string, thumbnailBuffer: Buffer)

(I'm not sure what that flow type should be)

We shouldn't need to do this because we've declared that `filePath` will be a string. Maybe we should add a second argument for a buffer? `export const doUploadThumbnail = (filePath?: string, thumbnailBuffer: Buffer)` (I'm not sure what that flow type should be)
zxawry commented 2019-05-20 14:11:47 +02:00 (Migrated from github.com)
Review

I did as you said, but do you think wrapping them two in one object as an argument is any better?

I did as you said, but do you think wrapping them two in one object as an argument is any better?
neb-b commented 2019-05-20 19:31:35 +02:00 (Migrated from github.com)
Review

I think two arguments is fine.

I think two arguments is fine.
}); });
export const doUploadThumbnail = (filePath: string) => (dispatch: Dispatch) => { export const doUploadThumbnail = (filePath: string, thumbnailBuffer: Uint8Array) => (dispatch: Dispatch) => {
const thumbnail = fs.readFileSync(filePath); let thumbnail, fileExt, fileName, fileType;
const fileExt = path.extname(filePath);
const fileName = path.basename(filePath); if (filePath) {
thumbnail = fs.readFileSync(filePath);
fileExt = path.extname(filePath);
fileName = path.basename(filePath);
fileType = `image/${fileExt.slice(1)}`;
} else if (thumbnailBuffer) {
thumbnail = thumbnailBuffer;
fileExt = '.png';
fileName = 'thumbnail.png';
fileType = 'image/png';
} else {
return null;
}
const makeid = () => { const makeid = () => {
let text = ''; let text = '';
@ -102,7 +114,7 @@ export const doUploadThumbnail = (filePath: string) => (dispatch: Dispatch) => {
const data = new FormData(); const data = new FormData();
const name = makeid(); const name = makeid();
const file = new File([thumbnail], fileName, { type: `image/${fileExt.slice(1)}` }); const file = new File([thumbnail], fileName, { type: fileType });
data.append('name', name); data.append('name', name);
data.append('file', file); data.append('file', file);