LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Minor fixes for channel-about page #2520

Merged
btzr-io merged 4 commits from channel-desc into master 2019-05-30 23:07:53 +02:00
Conversation 1 Commits 4 Files changed 4 +6 -1
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 9b9de07bfe - Show all commits

2
src/ui/component/channelAbout/view.jsx
View file

@ -27,7 +27,7 @@ function ChannelContent(props: Props) {
{showAbout && (
<Fragment>
{description && (
<div className="media__info-text">
<div className="media__info-text media__info-text--small">
<MarkdownPreview content={description} promptLinks />
</div>
)}

5
src/ui/scss/component/_media.scss
View file

@ -260,11 +260,16 @@
.media__info-text {
font-size: 1.15rem;
word-break: break-word;
neb-b commented 2019-05-30 01:04:05 +02:00 (Migrated from github.com)
Review
Copy link

This was used as a quick fix to prevent super long links from not wrapping. Checkout some of cryptocandors content to see it.

This was used as a quick fix to prevent super long links from not wrapping. Checkout some of cryptocandors content to see it.
neb-b commented 2019-05-30 01:05:11 +02:00 (Migrated from github.com)
Review
Copy link

Can we add a Max width on this for this? Mostly for the channel page.

Try editing the description to be really long to see the current issue.

Can we add a Max width on this for this? Mostly for the channel page. Try editing the description to be really long to see the current issue.
btzr-io commented 2019-05-30 03:03:28 +02:00 (Migrated from github.com)
Review
Copy link

Oh, I see, then I think word-break: break-word should work for both cases 👍

Oh, I see, then I think `word-break: break-word` should work for both cases :+1:
btzr-io commented 2019-05-30 03:14:13 +02:00 (Migrated from github.com)
Review
Copy link

@seanyesmunt How long should be the max-width ?

@seanyesmunt How long should be the `max-width` ?
btzr-io commented 2019-05-30 03:28:30 +02:00 (Migrated from github.com)
Review
Copy link

I added 70% as a random value, looks good in my screen 😛

I added `70%` as a random value, looks good in my screen :stuck_out_tongue:
&:not(:last-of-type) {
margin-bottom: var(--spacing-vertical-large);
}
&.media__info-text--small {
max-width: 70%;
}
&.media__info-text--center {
text-align: center;
}