Dynamic meta tags for content #2546

Merged
NetOpWibby merged 1 commit from 2410-meta-tags into master 2019-07-29 15:34:34 +02:00
2 changed files with 67 additions and 3 deletions

View file

@ -1,12 +1,76 @@
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
const { readFileSync } = require('fs');
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
const express = require('express');
const fetch = require('node-fetch');
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
const path = require('path');
const app = express();
const port = 1337;
const headRegex = /(<head>).*(<\/head>)/g;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
app.use(express.static(__dirname));
app.get('*', function(req, res) {
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
res.sendFile(path.join(__dirname, '/index.html'));
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
app.get('*', async (req, res) => {
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
let finalHtml = '';
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
let identifier = req.url.split('/').pop();
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
let isAppPage = req.url.includes('/$/');
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
let isChannel = req.url.includes('/@');
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
let queryUrl = '';
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
kauffj commented 2019-06-26 16:31:28 +02:00 (Migrated from github.com)
Review

This test probably needs to be stronger, as I think @ can technically appear in the middle of a claim name

This test probably needs to be stronger, as I think `@` can technically appear in the middle of a claim name
tzarebczan commented 2019-06-26 19:32:19 +02:00 (Migrated from github.com)
Review

@ is a reversed character.

@ is a reversed character.
switch (true) {
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
case isAppPage:
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
return res.sendFile(path.join(__dirname, '/index.html'));
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
case isChannel:
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
queryUrl = `https://chainquery.lbry.io/api/sql?query=SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="${identifier}"`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
break;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
kauffj commented 2019-06-26 16:30:47 +02:00 (Migrated from github.com)
Review

@sayplastic (or @nikooo777?) is there a better way for @NetOperatorWibby to be getting data from chainquery for lbry.tv than this?

@sayplastic (or @nikooo777?) is there a better way for @NetOperatorWibby to be getting data from chainquery for lbry.tv than this?
nikooo777 commented 2019-07-02 03:35:12 +02:00 (Migrated from github.com)
Review

if this is serverside we can use a mysql connector, otherwise no, unless we proxy the calls.
Also this risks getting throttled by chainquery, I think there is a limit to how many queries can be sent to the web API

if this is serverside we can use a mysql connector, otherwise no, unless we proxy the calls. Also this risks getting throttled by chainquery, I think there is a limit to how many queries can be sent to the web API
NetOpWibby commented 2019-07-03 22:56:50 +02:00 (Migrated from github.com)
Review

How do I improve this?

How do I improve this?
nikooo777 commented 2019-07-08 13:19:51 +02:00 (Migrated from github.com)
Review

as first version we agreed that this is fine. however please update from .io to .com

as first version we agreed that this is fine. however please update from .io to .com
default:
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
// isContentPage
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
queryUrl = `https://chainquery.lbry.io/api/sql?query=SELECT * FROM claim where claim_id="${identifier}"`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
break;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
}
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
[finalHtml] = await Promise.all([
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
fetch(queryUrl)
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
.then(response => response.json())
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
.then(claim => {
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
if (!claim.success || !claim.data[0]) {
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
return path.join(__dirname, '/index.html');
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
}
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
claim = claim.data[0];
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
// const claimAuthor = claim.channel_name ? claim.channel_name : 'Anonymous'; // Currently unable to get creator name
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
const claimDescription =
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
claim.description && claim.description.length > 0 ? claim.description : `Watch ${claim.title} on LBRY.tv`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
const claimLanguage = claim.language || 'en_US';
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
const claimThumbnail = claim.thumbnail_url || '/og.png';
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
const claimTitle = `${claim.title} on LBRY.tv` || 'LBRY.tv'; // `${claim.title} from ${claimAuthor} on LBRY.tv`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
const claimUrl =
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
`https://beta.lbry.tv/${claim.name}${claim.claim_id ? `/${claim.claim_id}` : ''}` || 'https://beta.lbry.tv';
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
// This comment was inlined and preventing the rest of the script to load
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
const indexHtml = readFileSync(path.join(__dirname, '/index.html'), 'utf8')
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
.replace(/\s\s/gm, '')
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
.replace(/>\s</gm, '><')
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
.replace('// Use relative path if we are in electron', '');
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
let finalTags = '';
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += '<meta charset="utf8"/>';
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<meta name="description" content="${claimDescription}"/>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<meta name="keywords" content="${claim.tags ? claim.tags.toString() : ''}"/>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<meta name="twitter:image" content="${claimThumbnail}"/>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<meta property="og:description" content="${claimDescription}"/>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<meta property="og:image" content="${claimThumbnail}"/>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<meta property="og:locale" content="${claimLanguage}"/>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<meta property="og:site_name" content="LBRY.tv"/>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<meta property="og:type" content="website"/>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<meta property="og:url" content="${claimUrl}"/>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
finalTags += `<title>${claimTitle}</title>`;
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
return indexHtml.replace(indexHtml.match(headRegex)[0], finalTags);
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
}),
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
]);
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
res.send(finalHtml);
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
});
app.listen(port, () => console.log(`UI server listening at http://localhost:${port}`));

tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?
tzarebczan commented 2019-06-19 00:37:46 +02:00 (Migrated from github.com)
Review

thumbnail misspelled :)

thumbnail misspelled :)
tzarebczan commented 2019-06-19 00:41:43 +02:00 (Migrated from github.com)
Review

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d"

Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.

Query with a channel: SELECT channel.name as channel, claim.name, claim.description, claim.language, claim.thumbnail_url, claim.title FROM claim left join claim channel on claim.publisher_id = channel.claim_id where claim.claim_id="93a61971c473ade02300361dc077eb564b558a8d" Will we always have the claim id? does that come from the claim that's resolved? What if someone shares beta.lbry.tv/jiggytom Sounds like we'll need to use claim.name = xxx and bid_state = controlling per my original suggestion in that case.
tzarebczan commented 2019-06-19 01:03:22 +02:00 (Migrated from github.com)
Review

I saw we grab claim id from the URL, so we'll need to adjust the query as such.

I saw we grab claim id from the URL, so we'll need to adjust the query as such.
kauffj commented 2019-06-26 16:26:36 +02:00 (Migrated from github.com)
Review

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely.

(Additionally, this approach could cause a race condition among two requests that came in simultaneously)

Is this code writing the HTML to disk only to read it back? If I'm understanding what this does correctly, it seems like it could be skipped entirely. (Additionally, this approach could cause a race condition among two requests that came in simultaneously)
kauffj commented 2019-06-26 16:26:57 +02:00 (Migrated from github.com)
Review

Can these values be injected into the HTML file rather than built in JS?

Can these values be injected into the HTML file rather than built in JS?
kauffj commented 2019-06-26 16:27:45 +02:00 (Migrated from github.com)
Review

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

How about a fallback of "Watch %content_title% on lbry.tv" or "Watch %content_title% from %creator% on lbry.tv"?

View file

@ -8,7 +8,7 @@
<!-- @if TARGET='web' -->
<title>lbry.tv</title>
<meta property="og:url" content="https://beta.lbry.tv" />
<meta property="og:title" content="LBRY On The Web" />
<meta property="og:title" content="LBRY.tv" />
<meta property="og:description" content="All your favorite LBRY content in your browser." />
<meta property="og:image" content="/og.png" />
<!-- @endif -->