LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Discovery fixes #2576

Merged
neb-b merged 10 commits from discovery-fixes into master 2019-06-28 09:27:56 +02:00
Conversation 0 Commits 10 Files changed 77 +4 -2
4 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 27bca1f478 - Show all commits

1
src/ui/component/publishFile/view.jsx
View file

@ -41,6 +41,7 @@ function PublishFile(props: Props) {
<FileSelector currentPath={filePath} onFileChosen={handleFileChange} />
{!!isStillEditing && name && (
<p className="help">
{/* @i18nfixme */}
{__("If you don't choose a file, the file from your existing claim")}
kauffj commented 2019-06-27 22:18:33 +02:00 (Migrated from github.com)
Review
Copy link

When you notice split i18n strings like this, can you add an annotation of some kind? (I propose //@i18nfixme)

When you notice split i18n strings like this, can you add an annotation of some kind? (I propose `//@i18nfixme`)
{` "${name}" `}
{__('will be used.')}

2
src/ui/component/publishFormErrors/view.jsx
View file

@ -26,7 +26,7 @@ function PublishFormErrors(props: Props) {
kauffj commented 2019-06-27 22:20:06 +02:00 (Migrated from github.com)
Review
Copy link

Can this be re-written to say "Please"?

(also, why is this necessary?)

Can this be re-written to say "Please"? (also, why is this necessary?)
neb-b commented 2019-06-28 09:07:42 +02:00 (Migrated from github.com)
Review
Copy link

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.
kauffj commented 2019-06-27 22:20:06 +02:00 (Migrated from github.com)
Review
Copy link

Can this be re-written to say "Please"?

(also, why is this necessary?)

Can this be re-written to say "Please"? (also, why is this necessary?)
neb-b commented 2019-06-28 09:07:42 +02:00 (Migrated from github.com)
Review
Copy link

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.
<div>{__('Please wait for thumbnail to finish uploading')}</div>
)}
{!!editingURI && !isStillEditing && !filePath && (
<div>{__('You need to reselect a file after changing the LBRY URL')}</div>
kauffj commented 2019-06-27 22:20:06 +02:00 (Migrated from github.com)
Review
Copy link

Can this be re-written to say "Please"?

(also, why is this necessary?)

Can this be re-written to say "Please"? (also, why is this necessary?)
neb-b commented 2019-06-28 09:07:42 +02:00 (Migrated from github.com)
Review
Copy link

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.
<div>{__('Please reselect a file after changing the LBRY URL')}</div>
kauffj commented 2019-06-27 22:20:06 +02:00 (Migrated from github.com)
Review
Copy link

Can this be re-written to say "Please"?

(also, why is this necessary?)

Can this be re-written to say "Please"? (also, why is this necessary?)
neb-b commented 2019-06-28 09:07:42 +02:00 (Migrated from github.com)
Review
Copy link

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.
)}
</div>
);

kauffj commented 2019-06-27 22:20:06 +02:00 (Migrated from github.com)
Review
Copy link

Can this be re-written to say "Please"?

(also, why is this necessary?)

Can this be re-written to say "Please"? (also, why is this necessary?)
neb-b commented 2019-06-28 09:07:42 +02:00 (Migrated from github.com)
Review
Copy link

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.
kauffj commented 2019-06-27 22:20:06 +02:00 (Migrated from github.com)
Review
Copy link

Can this be re-written to say "Please"?

(also, why is this necessary?)

Can this be re-written to say "Please"? (also, why is this necessary?)
neb-b commented 2019-06-28 09:07:42 +02:00 (Migrated from github.com)
Review
Copy link

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.

It shouldn't be, but we aren't currently tracking the previous claim, after you change the name, because that could be another claim.

1
src/ui/component/publishName/bid-help-text.jsx
View file

@ -16,6 +16,7 @@ function BidHelpText(props: Props) {
} else if (!amountNeededForTakeover) {
bidHelpText = __('Any amount will give you the winning bid.');
} else {
// @i18nfixme
bidHelpText = `${__('If you bid more than')} ${amountNeededForTakeover} LBC, ${__(
kauffj commented 2019-06-27 22:20:55 +02:00 (Migrated from github.com)
Review
Copy link

@i18nfixme

(also, these split strings are basically not worth even calling the function on, but should be tagged either way)

`@i18nfixme` (also, these split strings are basically not worth even calling the function on, but should be tagged either way)
'when someone navigates to'
)} ${uri} ${__('it will load your published content')}. ${__(

2
src/ui/component/selectThumbnail/view.jsx
View file

@ -167,7 +167,7 @@ class SelectThumbnail extends React.PureComponent<Props, State> {
__('Enter a URL for your thumbnail.')
) : (
<React.Fragment>
{__('Upload your thumbnail (.png/.jpg/.jpeg/.gif) to')}{' '}
{__('Upload your thumbnail to')}{' '}
<Button button="link" label={__('spee.ch')} href="https://spee.ch/about" />.{' '}
{__('Recommended size: 800x450 (16:9)')}
</React.Fragment>