LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Issue #312 home page scroll position on back navigation #331

Merged
akinwale merged 3 commits from issue312 into master 2017-07-18 20:32:54 +02:00
Conversation 9 Commits 3 Files changed 6 +19 -1
1 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 52b404b552 - Show all commits

20
ui/js/page/discover/view.jsx
View file

@ -3,6 +3,7 @@ import lbryio from "lbryio.js";
import lbryuri from "lbryuri";
import FileCard from "component/fileCard";
import { BusyMessage } from "component/common.js";
import { setSession, getSession } from "utils";
import ToolTip from "component/tooltip.js";
const FeaturedCategory = props => {
@ -37,10 +38,27 @@ const FeaturedCategory = props => {
class DiscoverPage extends React.PureComponent {
componentWillMount() {
this.props.fetchFeaturedUris();
this.scrollListener = this.handleScroll.bind(this);
}
componentDidMount() {
const scrollY = parseInt(getSession("prefs_scrolly"));
if (!isNaN(scrollY)) {
const restoreScrollPosition = () => {
window.scrollTo(0, scrollY);
};
setTimeout(restoreScrollPosition, 100);
}
window.addEventListener("scroll", this.scrollListener);
}
handleScroll() {
setSession("prefs_scrolly", window.scrollY);
}
componentWillUnmount() {
this.props.cancelResolvingUris();
akinwale commented 2017-07-13 23:56:01 +02:00 (Migrated from github.com)
Review
Copy link

@kauffj This delegates to doHistoryBackCompleted(). I called it at this point because the popstate event was not being fired after clicking the back button. Also, HISTORY_BACK occurs before CHANGE_PATH, and this happens before componentDidMount. I needed a way to reliably detect that the user navigated using the back button and being able to check the flag when the component mounts was how I could do it (although I figure there might be a better way but I'm not seeing it at this point).

@kauffj This delegates to `doHistoryBackCompleted()`. I called it at this point because the `popstate` event was not being fired after clicking the back button. Also, `HISTORY_BACK` occurs before `CHANGE_PATH`, and this happens before `componentDidMount`. I needed a way to reliably detect that the user navigated using the back button and being able to check the flag when the component mounts was how I could do it (although I figure there might be a better way but I'm not seeing it at this point).
window.removeEventListener("scroll", this.scrollListener);
}
render() {
@ -51,7 +69,7 @@ class DiscoverPage extends React.PureComponent {
(featuredUris !== undefined && Object.keys(featuredUris).length === 0));
return (
<main>
<main ref="main">
{fetchingFeaturedUris &&
<BusyMessage message={__("Fetching content")} />}
{typeof featuredUris === "object" &&