LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

Right Click to Navigate History #3547

Merged
dalhill merged 11 commits from 3474-history-buttons into master 2020-02-03 16:19:16 +01:00
Conversation 3 Commits 11 Files changed 10 +1
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 5d23301b68 - Show all commits

1
ui/component/navigationButton/view.jsx
View file

@ -67,6 +67,7 @@ const NavigationButton = (props: Props) => {
}} }}
icon={isBackward ? ICONS.ARROW_LEFT : ICONS.ARROW_RIGHT} icon={isBackward ? ICONS.ARROW_LEFT : ICONS.ARROW_RIGHT}
iconSize={18} iconSize={18}
disabled={slicedEntries.length === 0}
/> />
neb-b commented 2020-01-27 16:57:36 +01:00 (Migrated from github.com)
Review
Copy link

Are you able to determine if we can go back here or not? If so, it would be great to disable the back button and give it some disabled style so it's easier to tell that you can't

Are you able to determine if we can go back here or not? If so, it would be great to disable the back button and give it some disabled style so it's easier to tell that you can't
dalhill commented 2020-01-28 02:07:31 +01:00 (Migrated from github.com)
Review
Copy link

PR has been updated to disable button if no historical entries.

PR has been updated to disable button if no historical entries.
neb-b commented 2020-01-28 16:24:37 +01:00 (Migrated from github.com)
Review
Copy link

Awesome!

Awesome!
{showHistory && <ul className={'header__navigaiton-dropdown'}>{slicedEntries.map(makeItem)}</ul>} {showHistory && <ul className={'header__navigaiton-dropdown'}>{slicedEntries.map(makeItem)}</ul>}
</div> </div>