[WIP] Discover page horizontal scroll implementation #394

Closed
akinwale wants to merge 7 commits from ui-category-carousel into master
3 changed files with 258 additions and 39 deletions

View file

@ -1,15 +1,180 @@
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
import React from "react";
import ReactDOM from "react-dom";
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
import lbryio from "lbryio.js";
import lbryuri from "lbryuri";
import FileCard from "component/fileCard";
import { BusyMessage } from "component/common.js";
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
import { Icon, BusyMessage } from "component/common.js";
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
import ToolTip from "component/tooltip.js";
const FeaturedCategory = props => {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const { category, names } = props;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
class FeaturedCategory extends React.PureComponent {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
componentWillMount() {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
this.setState({
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
numItems: this.props.names.length,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
canScrollPrevious: false,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
canScrollNext: true,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
});
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
handleScrollPrevious() {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cardRow = ReactDOM.findDOMNode(this.refs.rowitems);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (cardRow.scrollLeft > 0) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
// check the visible cards
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cards = cardRow.getElementsByTagName("section");
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
let firstVisibleCard = null;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
let firstVisibleIdx = -1;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
for (var i = 0; i < cards.length; i++) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (this.isCardVisible(cards[i], cardRow, false)) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
firstVisibleCard = cards[i];
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
firstVisibleIdx = i;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
break;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const numDisplayed = this.numDisplayedCards(cardRow);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const scrollToIdx = firstVisibleIdx - numDisplayed;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const animationCallback = () => {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
this.setState({
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
canScrollPrevious: cardRow.scrollLeft !== 0,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
canScrollNext: true,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
});
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
};
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
this.scrollCardItemsLeftAnimated(
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
cardRow,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
scrollToIdx < 0 ? 0 : cards[scrollToIdx].offsetLeft,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
100,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
animationCallback
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
handleScrollNext() {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cardRow = ReactDOM.findDOMNode(this.refs.rowitems);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
// check the visible cards
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cards = cardRow.getElementsByTagName("section");
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
let lastVisibleCard = null;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
let lastVisibleIdx = -1;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
for (var i = 0; i < cards.length; i++) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (this.isCardVisible(cards[i], cardRow, true)) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
lastVisibleCard = cards[i];
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
lastVisibleIdx = i;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (lastVisibleCard) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const numDisplayed = this.numDisplayedCards(cardRow);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const animationCallback = () => {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
// update last visible index after scroll
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
for (var i = 0; i < cards.length; i++) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (this.isCardVisible(cards[i], cardRow, true)) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
lastVisibleIdx = i;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
this.setState({ canScrollPrevious: true });
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (lastVisibleIdx === cards.length - 1) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
this.setState({ canScrollNext: false });
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
};
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
this.scrollCardItemsLeftAnimated(
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
cardRow,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
Math.min(
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
lastVisibleCard.offsetLeft,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
cardRow.scrollWidth - cardRow.clientWidth
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
),
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
100,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
animationCallback
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
scrollCardItemsLeftAnimated(cardRow, target, duration, callback) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (!duration || duration <= diff) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
cardRow.scrollLeft = target;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (callback) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
callback();
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
return;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const component = this;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const diff = target - cardRow.scrollLeft;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const tick = diff / duration * 10;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
setTimeout(() => {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
cardRow.scrollLeft = cardRow.scrollLeft + tick;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (cardRow.scrollLeft === target) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (callback) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
callback();
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
return;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
component.scrollCardItemsLeftAnimated(
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
cardRow,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
target,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
duration - 10,
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
callback
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}, 10);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
isCardVisible(section, cardRow, partialVisibility) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
// check if a card is fully or partialy visible in its parent
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cardRowWidth = cardRow.offsetWidth;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cardRowLeft = cardRow.scrollLeft;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cardRowEnd = cardRowLeft + cardRow.offsetWidth;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const sectionLeft = section.offsetLeft - cardRowLeft;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const sectionEnd = sectionLeft + section.offsetWidth;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
return (
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
(sectionLeft >= 0 && sectionEnd <= cardRowWidth) ||
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
(((sectionLeft < 0 && sectionEnd > 0) ||
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
(sectionLeft > 0 && sectionLeft <= cardRowWidth)) &&
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
partialVisibility)
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
numDisplayedCards(cardRow) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cards = cardRow.getElementsByTagName("section");
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cardRowWidth = cardRow.offsetWidth;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
// get the width of the first card and then calculate
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const cardWidth = cards.length > 0 ? cards[0].offsetWidth : 0;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
if (cardWidth > 0) {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
return Math.ceil(cardRowWidth / cardWidth);
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
// return a default value of 1 card displayed if the card width couldn't be determined
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
return 1;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
render() {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const { category, names } = this.props;
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const leftNavClassName =
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
"card-row__nav left-nav" +
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
(this.state.canScrollPrevious ? " can-scroll" : "");
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
const rightNavClassName =
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
"card-row__nav right-nav" +
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
(this.state.canScrollNext ? " can-scroll" : "");
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
return (
<div className="card-row card-row--small">
<div className={leftNavClassName}>
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
<a
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
className="card-row__scroll-button"
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
onClick={this.handleScrollPrevious.bind(this)}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
>
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
<Icon icon="icon-chevron-left" />
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
</a>
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
</div>
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
<div className={rightNavClassName}>
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
<a
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
className="card-row__scroll-button"
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
onClick={this.handleScrollNext.bind(this)}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
>
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
<Icon icon="icon-chevron-right" />
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
</a>
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
</div>
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
<h3 className="card-row__header">
{category}
{category &&
@ -22,6 +187,7 @@ const FeaturedCategory = props => {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
className="tooltip--header"
/>}
</h3>
<div ref="rowitems" className="card-row__items">
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
{names &&
names.map(name =>
<FileCard
@ -31,8 +197,10 @@ const FeaturedCategory = props => {
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
/>
)}
</div>
</div>
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
);
};
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
}
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
class DiscoverPage extends React.PureComponent {
componentWillMount() {

kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P
kauffj commented 2017-07-28 00:13:57 +02:00 (Migrated from github.com)
Review

Would it be cleaner to handle this just by wrapping the <Icon> in something like <a onClick={this.handleScrollNext.bind(this)} />?

Would it be cleaner to handle this just by wrapping the `<Icon>` in something like `<a onClick={this.handleScrollNext.bind(this)} />`?
kauffj commented 2017-07-28 00:16:00 +02:00 (Migrated from github.com)
Review

No var :P

No `var` :P

View file

@ -1,6 +1,7 @@
@import "../global";
$padding-card-horizontal: $spacing-vertical * 2/3;
$translate-card-hover: 10px;
.card {
margin-left: auto;
@ -94,10 +95,13 @@ $card-link-scaling: 1.1;
position: relative;
z-index: 1;
box-shadow: $box-shadow-focus;
transform: scale($card-link-scaling);
transform: scale($card-link-scaling) translate3d($translate-card-hover, 0, 0);
transform-origin: 50% 50%;
overflow-x: visible;
overflow-y: visible;
overflow-y: visible
}
.card--link:hover ~ .card--link {
transform: translate3d($translate-card-hover * 2, 0, 0);
}
.card__media {
@ -183,26 +187,73 @@ $height-card-small: $spacing-vertical * 15;
}
.card-row {
+ .card-row {
margin-top: $spacing-vertical * 1/3;
}
}
.card-row__items {
> .card {
vertical-align: top;
display: inline-block;
margin-right: $spacing-vertical / 3;
}
+ .card-row {
margin-top: $spacing-vertical * 1/3;
> .card:last-child {
margin-right: 0
}
}
.card-row--small {
overflow-x: auto;
overflow-y: hidden;
overflow: hidden;
white-space: nowrap;
position: relative;
/*hacky way to give space for hover */
padding-left: 20px;
margin-left: -20px;
padding-right: 20px;
margin-right: -20px;
padding-right: 30px;
}
.card-row__items {
width: 100%;
overflow: hidden;
/*hacky way to give space for hover */
padding-top: 20px;
margin-top: -20px;
padding-right: 30px;
margin-right: -30px;
}
.card-row__header {
margin-bottom: $spacing-vertical / 3;
}
.card-row__nav {
display: none;
position: absolute;
padding: 0 $spacing-vertical / 1.5;
top: ($font-size * 1.4 * $font-line-height) + ($spacing-vertical / 3);
height: ($width-card-small * 9 / 16) + ($font-size * 0.82 * $font-line-height * 4) + ($spacing-vertical * 4/3)
}
.card-row__nav .card-row__scroll-button {
background: $color-bg;
color: $color-help;
box-shadow: $box-shadow-layer;
padding: $spacing-vertical $spacing-vertical / 2;
position: absolute;
cursor: pointer;
left: 0;
top: 36%;
z-index: 2;
opacity: 0.5;
transition: transform 60ms ease-in-out;
&:hover {
opacity: 1.0;
transform: scale($card-link-scaling * 1.1)
}
}
.card-row__nav.left-nav {
left: 0;
}
.card-row__nav.right-nav {
right: 0;
}
.card-row__nav.can-scroll {
display: block
}

View file

@ -13,7 +13,7 @@ $color-header-active: darken($color-header, 20%);
top: 0;
left: 0;
width: 100%;
z-index: 2;
z-index: 3;
padding: $spacing-vertical / 2;
box-sizing: border-box;
}