LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

More stripe integration #6649

Closed
mayeaux wants to merge 17 commits from more-stripe-integration into master
pull from: more-stripe-integration
merge into: LBRYCommunity:master
Conversation 1 Commits 17 Files changed 7 +30 -49
1 changed files with 30 additions and 49 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 4e07558c9b - Show all commits

49
ui/component/livestreamComments/view.jsx
View file

@ -50,13 +50,23 @@ export default function LivestreamComments(props: Props) {
let { superChatsReversed, superChatsFiatAmount, superChatsTotalAmount } = props; let { superChatsReversed, superChatsFiatAmount, superChatsTotalAmount } = props;
// sum total amounts for fiat tips and lbc tips const commentsRef = React.createRef();
if(superChats){ const [scrollBottom, setScrollBottom] = React.useState(true);
const [viewMode, setViewMode] = React.useState(VIEW_MODE_CHAT);
const [performedInitialScroll, setPerformedInitialScroll] = React.useState(false);
const claimId = claim && claim.claim_id;
const commentsLength = comments && comments.length;
const commentsToDisplay = viewMode === VIEW_MODE_CHAT ? comments : superChats;
const discussionElement = document.querySelector('.livestream__comments');
jessopb commented 2021-07-29 23:17:20 +02:00 (Migrated from github.com)
Review
Copy link

One thing you can do is get
{ superChats: superchatsSortedByAmount, comments: superchatsSortedByDate } = props; to use a new name after destructuring.

One thing you can do is get { superChats: superchatsSortedByAmount, comments: superchatsSortedByDate } = props; to use a new name after destructuring.
jessopb commented 2021-07-29 23:19:59 +02:00 (Migrated from github.com)
Review
Copy link

Perhaps whatever is connect()ed in in the index.js could just have a better name.

Perhaps whatever is connect()ed in in the index.js could just have a better name.
const commentElement = document.querySelector('.livestream-comment');
// sum total amounts for fiat tips and lbc tips
if (superChats) {
let fiatAmount = 0; let fiatAmount = 0;
let LBCAmount = 0; let LBCAmount = 0;
for(const superChat of superChats){ for (const superChat of superChats) {
if(superChat.is_fiat){ if (superChat.is_fiat) {
fiatAmount = fiatAmount + superChat.support_amount; fiatAmount = fiatAmount + superChat.support_amount;
} else { } else {
LBCAmount = LBCAmount + superChat.support_amount; LBCAmount = LBCAmount + superChat.support_amount;
@ -67,25 +77,7 @@ export default function LivestreamComments(props: Props) {
superChatsTotalAmount = LBCAmount; superChatsTotalAmount = LBCAmount;
} }
// TODO: why doesn't this work? // array of superchats organized by fiat or not first, then support amount
React.useEffect(() => {
if(superChats){
console.log(superChats);
// let fiatAmount = 0;
// for(const superChat of superChats){
// if(superChat.is_fiat){
// fiatAmount = fiatAmount + superChat.support_amount;
// }
// }
//
// console.log(fiatAmount);
//
// superChatsFiatAmount = fiatAmount.toString();
}
}, [superChats]);
if (superChats) { if (superChats) {
const clonedSuperchats = JSON.parse(JSON.stringify(superChats)); const clonedSuperchats = JSON.parse(JSON.stringify(superChats));
@ -99,17 +91,6 @@ export default function LivestreamComments(props: Props) {
}).reverse(); }).reverse();
} }
const commentsRef = React.createRef();
const [scrollBottom, setScrollBottom] = React.useState(true);
const [viewMode, setViewMode] = React.useState(VIEW_MODE_CHAT);
const [performedInitialScroll, setPerformedInitialScroll] = React.useState(false);
const claimId = claim && claim.claim_id;
const commentsLength = comments && comments.length;
const commentsToDisplay = viewMode === VIEW_MODE_CHAT ? comments : superChats;
const discussionElement = document.querySelector('.livestream__comments');
const commentElement = document.querySelector('.livestream-comment');
// todo: implement comment_list --mine in SDK so redux can grab with selectCommentIsMine // todo: implement comment_list --mine in SDK so redux can grab with selectCommentIsMine
function isMyComment(channelId: string) { function isMyComment(channelId: string) {
if (myChannels != null && channelId != null) { if (myChannels != null && channelId != null) {