LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

More stripe integration #6649

Closed
mayeaux wants to merge 17 commits from more-stripe-integration into master
pull from: more-stripe-integration
merge into: LBRYCommunity:master
Conversation 1 Commits 17 Files changed 7 +6 -6
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit a60f2d19c3 - Show all commits

12
ui/component/livestreamComments/view.jsx
View file

@ -44,27 +44,27 @@ export default function LivestreamComments(props: Props) {
doCommentList, doCommentList,
fetchingComments, fetchingComments,
doSuperChatList, doSuperChatList,
superChatsTotalAmount,
myChannels, myChannels,
superChats, // superchats organized by tip amount superChats, // superchats organized by tip amount
} = props; } = props;
let { superChatsReversed, superChatsFiatAmount } = props; let { superChatsReversed, superChatsFiatAmount, superChatsTotalAmount } = props;
superChatsFiatAmount = 0;
// sum total amounts for fiat tips and lbc tips
if(superChats){ if(superChats){
console.log(superChats);
let fiatAmount = 0; let fiatAmount = 0;
let LBCAmount = 0;
for(const superChat of superChats){ for(const superChat of superChats){
if(superChat.is_fiat){ if(superChat.is_fiat){
fiatAmount = fiatAmount + superChat.support_amount; fiatAmount = fiatAmount + superChat.support_amount;
} else {
jessopb commented 2021-07-29 23:17:20 +02:00 (Migrated from github.com)
Review
Copy link

One thing you can do is get
{ superChats: superchatsSortedByAmount, comments: superchatsSortedByDate } = props; to use a new name after destructuring.

One thing you can do is get { superChats: superchatsSortedByAmount, comments: superchatsSortedByDate } = props; to use a new name after destructuring.
jessopb commented 2021-07-29 23:19:59 +02:00 (Migrated from github.com)
Review
Copy link

Perhaps whatever is connect()ed in in the index.js could just have a better name.

Perhaps whatever is connect()ed in in the index.js could just have a better name.
LBCAmount = LBCAmount + superChat.support_amount;
} }
} }
superChatsFiatAmount = fiatAmount; superChatsFiatAmount = fiatAmount;
superChatsTotalAmount = LBCAmount;
} }
// TODO: why doesn't this work? // TODO: why doesn't this work?